From: Kevin Wolf <kwolf@redhat.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] We need more reviewers/maintainers!!
Date: Tue, 13 Mar 2012 12:27:17 +0100 [thread overview]
Message-ID: <4F5F2F15.7010402@redhat.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1203121728570.923@kaball-desktop>
Am 12.03.2012 18:34, schrieb Stefano Stabellini:
> On Mon, 12 Mar 2012, Anthony Liguori wrote:
>> On 03/12/2012 12:06 PM, Stefano Stabellini wrote:
>>> Hi all,
>>> I don't mean to steer any controversy or start any flame wars here, but
>>> rather I want to point out a problem in the QEMU Community that is
>>> preventing us and other people from having a good experience working
>>> upstream with QEMU. Call it constructive criticism.
>>>
>>> Patches are being posted to the list that don't get any reviews at all.
>>> Other patches get reviewed the first time, then once they are reposted
>>> they don't get any other reviews or acked-by or reviewed-by.
>>
>> In all fairness, QEMU continues to grow year-to-year both in terms of total
>> commits and number of contributors.
>>
>> The area that we struggle with is infrequent contributors that contribute
>> non-trivial things and are write-only contributors.
>>
>> In this case, I really think the problem is expecting to be a write-only
>> contributor. Part of participating in a community is not only pushing your own
>> patches for acceptance but also reviewing other people's patches and
>> participating in the discussion. If everyone only sends patches and doesn't
>> review patches, then we'll never make progress.
>>
>> So I'd strongly suggest trying to spend some time reviewing other people's work.
>> Right now, there are at least four different efforts around migration yet I
>> don't see any of the people reviewing the other efforts. I think this is really
>> the main problem.
>
> Point taken.
> However maintainers should also be responsible of reviewing patches of
> "infrequent write-only contributors".
Yes, but maintainers are overloaded because they also need to review
patches of frequent write-only contributors.
Kevin
next prev parent reply other threads:[~2012-03-13 11:24 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-12 17:06 [Qemu-devel] We need more reviewers/maintainers!! Stefano Stabellini
2012-03-12 17:16 ` Anthony Liguori
2012-03-12 17:34 ` Stefano Stabellini
2012-03-12 18:48 ` Anthony Liguori
2012-03-12 19:10 ` Stefano Stabellini
2012-03-12 19:04 ` Anthony Liguori
2012-03-12 19:21 ` Stefano Stabellini
2012-03-12 19:38 ` Anthony Liguori
2012-03-13 11:34 ` Stefano Stabellini
2012-03-13 11:27 ` Kevin Wolf [this message]
2012-03-13 11:41 ` Stefano Stabellini
2012-03-13 12:12 ` Paolo Bonzini
2012-03-12 18:03 ` Lluís Vilanova
2012-03-12 18:10 ` Anthony Liguori
2012-03-12 19:39 ` Lluís Vilanova
2012-03-12 19:43 ` Anthony Liguori
2012-03-12 18:18 ` Stefano Stabellini
2012-03-13 13:27 ` Avi Kivity
2012-03-14 13:50 ` Andreas Färber
2012-03-14 13:52 ` Anthony Liguori
2012-03-14 13:58 ` Peter Maydell
2012-03-14 14:17 ` Anthony Liguori
2012-03-14 14:25 ` Andreas Färber
2012-03-13 10:38 ` Andreas Färber
2012-03-12 19:18 ` Michael Roth
2012-03-13 11:11 ` Stefano Stabellini
2012-03-12 20:12 ` Stefan Weil
2012-03-12 20:24 ` Peter Maydell
2012-03-12 20:29 ` Anthony Liguori
2012-03-12 20:43 ` Peter Maydell
2012-03-12 21:06 ` Anthony Liguori
2012-03-12 21:09 ` malc
2012-03-12 21:13 ` Anthony Liguori
2012-03-12 21:41 ` Stefan Weil
2012-03-12 21:52 ` Anthony Liguori
2012-03-12 21:43 ` malc
2012-03-12 21:49 ` Anthony Liguori
2012-03-12 22:53 ` malc
2012-03-12 21:16 ` Peter Maydell
2012-03-12 21:19 ` Anthony Liguori
2012-03-13 10:39 ` Stefan Hajnoczi
2012-03-12 20:40 ` Michael S. Tsirkin
2012-03-12 20:27 ` Anthony Liguori
2012-03-12 21:12 ` Stefan Weil
2012-03-12 21:18 ` Anthony Liguori
2012-03-12 23:32 ` Andreas Färber
2012-03-13 0:16 ` Anthony Liguori
2012-03-13 0:54 ` Alexander Graf
2012-03-13 1:01 ` Andreas Färber
2012-03-13 1:23 ` Alexander Graf
2012-03-13 1:31 ` Super Bisquit
2012-03-13 1:39 ` Anthony Liguori
2012-03-13 2:04 ` Alexander Graf
2012-03-13 2:05 ` Anthony Liguori
2012-03-14 19:47 ` Blue Swirl
2012-03-13 9:09 ` Peter Maydell
2012-03-13 13:50 ` Avi Kivity
2012-03-13 14:12 ` Peter Maydell
2012-03-13 14:39 ` Avi Kivity
2012-03-13 14:43 ` Anthony Liguori
2012-03-13 14:46 ` Alexander Graf
2012-03-13 14:54 ` Peter Maydell
2012-03-13 14:49 ` Andreas Färber
2012-03-13 14:57 ` Avi Kivity
2012-03-13 15:13 ` Eric Blake
2012-03-12 21:24 ` Stefan Weil
2012-03-13 13:40 ` Avi Kivity
2012-03-13 14:00 ` Anthony Liguori
2012-03-13 14:38 ` Avi Kivity
2012-03-13 14:41 ` Anthony Liguori
2012-03-14 20:00 ` Blue Swirl
2012-03-14 19:55 ` Blue Swirl
2012-03-13 10:41 ` Stefan Hajnoczi
2012-03-13 16:31 ` Andreas Färber
2012-03-13 18:14 ` Stefan Weil
2012-03-14 9:17 ` Stefan Hajnoczi
2012-07-18 9:28 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5F2F15.7010402@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).