From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36607)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1S7R3S-0003Hp-GV
	for qemu-devel@nongnu.org; Tue, 13 Mar 2012 08:42:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1S7R3M-0006B4-AX
	for qemu-devel@nongnu.org; Tue, 13 Mar 2012 08:42:18 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:43516)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1S7R3M-0006Ac-3q
	for qemu-devel@nongnu.org; Tue, 13 Mar 2012 08:42:12 -0400
Received: by yenr5 with SMTP id r5so557091yen.4
	for <qemu-devel@nongnu.org>; Tue, 13 Mar 2012 05:42:10 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4F5F409C.5050200@redhat.com>
Date: Tue, 13 Mar 2012 13:42:04 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1331642087-21325-1-git-send-email-kraxel@redhat.com>
In-Reply-To: <1331642087-21325-1-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RfC PATCH] usb/vmstate: add parent dev path
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

Il 13/03/2012 13:34, Gerd Hoffmann ha scritto:
> ... to make vmstate id string truely unique with multiple host
> controllers, i.e. move from "1/usb-ptr" to "0000:00:01.3/1/usb-ptr"
> (usb tabled connected to piix3 uhci).
> 
> This is needed in case you have multiple USB busses in a virtual
> machine to make sure the section names are unique.  Obviously this
> will break migration.  I'm sitting on the patch for a while already,
> with the plan to sneak it in when we have a migration flag day anyway
> for the planned new & shiny migration format.
> 
> It doesn't look like this is going to happen anytime soon.  I'd like to
> have this fixed in the 1.1 release.  Suggestions how to go forward?

Add a property to the hcd devices, and set it to false for compatibility
machines?

That is

-    if (id) {
+    if (id && qdev_get_bit(hcd, "full-device-path")) {

BTW, your recently added serial.wakeup property uses a uint32... any
chance you could change it to a bit so that -global isa-serial.wakeup=on
works (nicer than =1 imho)?

Paolo