From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7Rxf-0002mi-Qy for qemu-devel@nongnu.org; Tue, 13 Mar 2012 09:40:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7Rxe-00050F-4z for qemu-devel@nongnu.org; Tue, 13 Mar 2012 09:40:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20467) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7Rxd-0004zu-Th for qemu-devel@nongnu.org; Tue, 13 Mar 2012 09:40:22 -0400 Message-ID: <4F5F4E3B.5040306@redhat.com> Date: Tue, 13 Mar 2012 15:40:11 +0200 From: Avi Kivity MIME-Version: 1.0 References: <4F5E58BE.6040808@weilnetz.de> <4F5E5C49.6060900@codemonkey.ws> In-Reply-To: <4F5E5C49.6060900@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] We need more reviewers/maintainers!! List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Stefan Weil , qemu-devel@nongnu.org, Stefano Stabellini On 03/12/2012 10:27 PM, Anthony Liguori wrote: >> I agree that more maintainers would be good, but we also need >> more people with commit rights. > > I disagree strongly. Having multiple pushers makes things difficult > and encourages people to push without testing. Part of what makes > pushing take longer than it should today is that my test cycle takes > at least 1-2 hours and it's not uncommon to have to go through 3-4 > cycles of rebasing before being able to push. This really sucks. If testing was automated, we could have a staging branch where maintainers would push patches, they'd get tested automatically and then graduate to master. The workflow would look something like git fetch git checkout staging git rebase origin/staging git push staging If testing cannot be automated, perhaps a lock around the tree would help. -- error compiling committee.c: too many arguments to function