From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7SNN-0003YO-GU for qemu-devel@nongnu.org; Tue, 13 Mar 2012 10:07:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7SNH-0002bL-Bt for qemu-devel@nongnu.org; Tue, 13 Mar 2012 10:06:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45295) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7SNH-0002bB-3s for qemu-devel@nongnu.org; Tue, 13 Mar 2012 10:06:51 -0400 Message-ID: <4F5F5474.1000502@redhat.com> Date: Tue, 13 Mar 2012 15:06:44 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1331641907-8348-1-git-send-email-bos@je-eigen-domein.nl> <4F5F453A.7020606@redhat.com> <4F5F5158.6050503@je-eigen-domein.nl> In-Reply-To: <4F5F5158.6050503@je-eigen-domein.nl> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/3] [v2] ide: Adds wwn=hex qdev option allowing the user to specify a disk's World Wide Name List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Floris Bos / Maxnet Cc: kwolf@redhat.com, qemu-devel@nongnu.org Il 13/03/2012 14:53, Floris Bos / Maxnet ha scritto: >> Words 84, 87, 108-111 should also be set in the ide_atapi_identify >> routine: - 84 and 87 to 0x4000 if no WWN, 0x4100 if WWN provided - >> 108..111 to the WWN in the same awkward-endian layout. Otherwise looks >> good. Paolo > > I leave it to someone else to write a patch for the ATAPI/CF-ATA stuff. > I'm not sure if there's a real use-case for WWN's for removable storage. > > And I am not so familiar with the ATA specification that I feel > confident enough to make changes that also result in different behavior > when no WWN is present. > 84 and 87 are currently not set at all in ide_atapi_identify. Fair enough, thanks! Paolo