From: Kevin Wolf <kwolf@redhat.com>
To: Floris Bos / Maxnet <bos@je-eigen-domein.nl>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] [v2] ide: Adds wwn=hex qdev option allowing the user to specify a disk's World Wide Name
Date: Tue, 13 Mar 2012 15:18:56 +0100 [thread overview]
Message-ID: <4F5F5750.2090200@redhat.com> (raw)
In-Reply-To: <4F5F5158.6050503@je-eigen-domein.nl>
Am 13.03.2012 14:53, schrieb Floris Bos / Maxnet:
> On 03/13/2012 02:01 PM, Paolo Bonzini wrote:
>> Words 84, 87, 108-111 should also be set in the ide_atapi_identify
>> routine: - 84 and 87 to 0x4000 if no WWN, 0x4100 if WWN provided -
>> 108..111 to the WWN in the same awkward-endian layout. Otherwise looks
>> good. Paolo
>
> I leave it to someone else to write a patch for the ATAPI/CF-ATA stuff.
> I'm not sure if there's a real use-case for WWN's for removable storage.
Okay, fine with me. Applied your patches to the block branch now.
Kevin
prev parent reply other threads:[~2012-03-13 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-13 12:31 [Qemu-devel] [PATCH 3/3] [v2] ide: Adds wwn=hex qdev option allowing the user to specify a disk's World Wide Name Floris Bos
2012-03-13 13:01 ` Paolo Bonzini
2012-03-13 13:22 ` Kevin Wolf
2012-03-13 13:28 ` Paolo Bonzini
2012-03-13 13:53 ` Floris Bos / Maxnet
2012-03-13 14:06 ` Paolo Bonzini
2012-03-13 14:18 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5F5750.2090200@redhat.com \
--to=kwolf@redhat.com \
--cc=bos@je-eigen-domein.nl \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).