From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7Sub-0006zm-Pp for qemu-devel@nongnu.org; Tue, 13 Mar 2012 10:41:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7SuS-0002e6-Io for qemu-devel@nongnu.org; Tue, 13 Mar 2012 10:41:17 -0400 Received: from mail-pz0-f47.google.com ([209.85.210.47]:57141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7SuS-0002dh-Ap for qemu-devel@nongnu.org; Tue, 13 Mar 2012 10:41:08 -0400 Received: by dado14 with SMTP id o14so1072044dad.34 for ; Tue, 13 Mar 2012 07:41:06 -0700 (PDT) Message-ID: <4F5F5C7E.5040701@codemonkey.ws> Date: Tue, 13 Mar 2012 09:41:02 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <4F5E58BE.6040808@weilnetz.de> <4F5E5C49.6060900@codemonkey.ws> <4F5F4E3B.5040306@redhat.com> <4F5F52F8.1060601@codemonkey.ws> <4F5F5BC8.3060704@redhat.com> In-Reply-To: <4F5F5BC8.3060704@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] We need more reviewers/maintainers!! List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Stefan Weil , qemu-devel@nongnu.org, Stefano Stabellini On 03/13/2012 09:38 AM, Avi Kivity wrote: > On 03/13/2012 04:00 PM, Anthony Liguori wrote: >> On 03/13/2012 08:40 AM, Avi Kivity wrote: >>> On 03/12/2012 10:27 PM, Anthony Liguori wrote: >>>>> I agree that more maintainers would be good, but we also need >>>>> more people with commit rights. >>>> >>>> I disagree strongly. Having multiple pushers makes things difficult >>>> and encourages people to push without testing. Part of what makes >>>> pushing take longer than it should today is that my test cycle takes >>>> at least 1-2 hours and it's not uncommon to have to go through 3-4 >>>> cycles of rebasing before being able to push. >>> >>> This really sucks. >>> >>> If testing was automated, we could have a staging branch where >>> maintainers would push patches, they'd get tested automatically and then >>> graduate to master. The workflow would look something like >>> >>> git fetch >>> git checkout staging >>> git rebase origin/staging >>> >>> git push staging >>> >>> >> from the test system> >> >> The problem for me with this is that I test before I do a thorough >> review. I do a quick review, but not a line-by-line review. So I >> don't necessarily want to queue for push. > > Seems to me it's better to review before testing, no? I typically do a high level review before queuing for testing, but I don't do a line-by-line review for coding style or minor issues. The later must be done before committing no matter how many revisions are sent. It's more time efficient to catch a functional problem without doing the line-by-line review. Best case scenario is that the line-by-line review happens only once for a patch before it's committed. >>> If testing cannot be automated, perhaps a lock around the tree would >>> help. >> >> I think merging qemu-test into make check would help a lot. If all >> committers are running the same test suite before pushing, then this >> problem would become less common. It's livable now because most >> committers commit infrequently. >> >> But if we added more committers, it would become pretty problematic. > > I'm not arguing either for or against that, just trying to make the > commit process more efficient. Yup, and appreciate the suggestions. Regards, Anthony Liguori