From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: amit.shah@redhat.com, Orit Wasserman <owasserm@redhat.com>,
qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/3] virtio-blk: report non-zero status when failing SG_IO requests
Date: Tue, 13 Mar 2012 09:17:36 -0600 [thread overview]
Message-ID: <4F5F6510.8090501@redhat.com> (raw)
In-Reply-To: <4F5F4E06.8030804@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 865 bytes --]
On 03/13/2012 07:39 AM, Paolo Bonzini wrote:
> Il 13/03/2012 14:36, Orit Wasserman ha scritto:
>> I get to following compile error:
>> In function ‘virtio_blk_handle_request’:
>> virtio-blk.c:264:28: error: ‘status’ may be used uninitialized in this function [-Werror=uninitialized]
>> virtio-blk.c:151:9: note: ‘status’ was declared here
>> cc1: all warnings being treated as errors
>>
>> Are you using -disable-werror ?
>
> No, perhaps a different compiler though.
Or a difference in -O level. gcc is notoriously bad at missing
-Wuninitialized at -O0, and not warning until -O1 or -O2. [I'm still
impressed at how the Java language was able to mandate uninitialized
detection into the compiler as a required part of the language.]
--
Eric Blake eblake@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 620 bytes --]
next prev parent reply other threads:[~2012-03-13 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-07 18:01 [Qemu-devel] [PATCH 0/3] decouple VIRTIO_BLK_F_SCSI from SG_IO support Paolo Bonzini
2012-03-07 18:01 ` [Qemu-devel] [PATCH 1/3] virtio-blk: report non-zero status when failing SG_IO requests Paolo Bonzini
2012-03-13 13:36 ` Orit Wasserman
2012-03-13 13:39 ` Paolo Bonzini
2012-03-13 13:44 ` Orit Wasserman
2012-03-13 15:17 ` Eric Blake [this message]
2012-03-07 18:01 ` [Qemu-devel] [PATCH 2/3] virtio-blk: define VirtIOBlkConf Paolo Bonzini
2012-03-07 18:01 ` [Qemu-devel] [PATCH 3/3] virtio-blk: always enable VIRTIO_BLK_F_SCSI Paolo Bonzini
2012-03-12 14:32 ` [Qemu-devel] [PATCH 0/3] decouple VIRTIO_BLK_F_SCSI from SG_IO support Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5F6510.8090501@redhat.com \
--to=eblake@redhat.com \
--cc=amit.shah@redhat.com \
--cc=mst@redhat.com \
--cc=owasserm@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).