From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7TUG-0005g5-Sq for qemu-devel@nongnu.org; Tue, 13 Mar 2012 11:18:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7TTn-00028G-03 for qemu-devel@nongnu.org; Tue, 13 Mar 2012 11:18:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23779) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7TTm-00027y-Or for qemu-devel@nongnu.org; Tue, 13 Mar 2012 11:17:38 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q2DFHb4q022454 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 13 Mar 2012 11:17:37 -0400 Message-ID: <4F5F6510.8090501@redhat.com> Date: Tue, 13 Mar 2012 09:17:36 -0600 From: Eric Blake MIME-Version: 1.0 References: <1331143301-28408-1-git-send-email-pbonzini@redhat.com> <1331143301-28408-2-git-send-email-pbonzini@redhat.com> <4F5F4D4D.1060600@redhat.com> <4F5F4E06.8030804@redhat.com> In-Reply-To: <4F5F4E06.8030804@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enigEB3F9493546FBB21BEAEA09D" Subject: Re: [Qemu-devel] [PATCH 1/3] virtio-blk: report non-zero status when failing SG_IO requests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: amit.shah@redhat.com, Orit Wasserman , qemu-devel@nongnu.org, mst@redhat.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigEB3F9493546FBB21BEAEA09D Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 03/13/2012 07:39 AM, Paolo Bonzini wrote: > Il 13/03/2012 14:36, Orit Wasserman ha scritto: >> I get to following compile error: >> In function =91virtio_blk_handle_request=92: >> virtio-blk.c:264:28: error: =91status=92 may be used uninitialized in = this function [-Werror=3Duninitialized] >> virtio-blk.c:151:9: note: =91status=92 was declared here >> cc1: all warnings being treated as errors >> >> Are you using -disable-werror ? >=20 > No, perhaps a different compiler though. Or a difference in -O level. gcc is notoriously bad at missing -Wuninitialized at -O0, and not warning until -O1 or -O2. [I'm still impressed at how the Java language was able to mandate uninitialized detection into the compiler as a required part of the language.] --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enigEB3F9493546FBB21BEAEA09D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPX2UQAAoJEKeha0olJ0Nqq9YH+gO1XEuPWmJCy6J4H/9t0ur9 OOUwFMt1V1rrPuhO3n+u2BBfjxihfSvfgMUB/Lmx30z/UpWVsoVp5NmMVh2t6YSP pQUT2lo93zg+YS546QwaxmdEtOYunG/0jbZf8xKS9/BY+grR4ANvYujLDVf1krkL hfbA8JDknXqVHrMcfxamNBLu6qnaqe/CUhvivLsis9DZQa6DlUqjA6HJGQZFyHK3 EBhpYGBsOOFMLtC2aUVDKjmNHXKQlcm/21Ebrx6bk5kMhBJrYmzIZZ1ilKM0AKhq +K2E7yn6lK2hLcnX/6t2YxPTaitkRd5ZmNZWS/dWc0eq8NHqwMWP67D4awXrwGQ= =D9EH -----END PGP SIGNATURE----- --------------enigEB3F9493546FBB21BEAEA09D--