From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39254)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S7W7y-0004EW-6Q
	for qemu-devel@nongnu.org; Tue, 13 Mar 2012 14:07:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S7W7r-00080N-S6
	for qemu-devel@nongnu.org; Tue, 13 Mar 2012 14:07:17 -0400
Received: from mail-pz0-f47.google.com ([209.85.210.47]:52236)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S7W7r-0007zq-Ln
	for qemu-devel@nongnu.org; Tue, 13 Mar 2012 14:07:11 -0400
Received: by dado14 with SMTP id o14so1353673dad.34
	for <qemu-devel@nongnu.org>; Tue, 13 Mar 2012 11:07:10 -0700 (PDT)
Message-ID: <4F5F8CCA.6090000@codemonkey.ws>
Date: Tue, 13 Mar 2012 13:07:06 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1330893156-26569-1-git-send-email-afaerber@suse.de>
	<1331346496-10736-1-git-send-email-afaerber@suse.de>
	<1331346496-10736-10-git-send-email-afaerber@suse.de>
In-Reply-To: <1331346496-10736-10-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH RFC v4 09/44] hw/mc146818: Drop unneeded
 #includes
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: qemu-devel@nongnu.org

On 03/09/2012 08:27 PM, Andreas Färber wrote:
> pc.h and apic.h are not needed; apic.h would drag in x86 CPUState and
> is now included directly for TARGET_I386.
>
> isa.h is already #included from mc146818rtc.h.

Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>

Regards,

Anthony Liguori

>
> Signed-off-by: Andreas Färber<afaerber@suse.de>
> ---
>   hw/mc146818rtc.c |    2 --
>   1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
> index 8b5cf8c..2b59c36 100644
> --- a/hw/mc146818rtc.c
> +++ b/hw/mc146818rtc.c
> @@ -24,8 +24,6 @@
>   #include "hw.h"
>   #include "qemu-timer.h"
>   #include "sysemu.h"
> -#include "pc.h"
> -#include "isa.h"
>   #include "mc146818rtc.h"
>
>   #ifdef TARGET_I386