From: Harsh Bora <harsh@linux.vnet.ibm.com>
To: "Lluís Vilanova" <vilanova@ac.upc.edu>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org,
aneesh.kumar@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [RFC PATCH v5 10/14] trace: Provide a per-event status define for conditional compilation
Date: Wed, 14 Mar 2012 10:55:52 +0530 [thread overview]
Message-ID: <4F602BE0.60201@linux.vnet.ibm.com> (raw)
In-Reply-To: <87ipi9kfii.fsf@ginnungagap.bsc.es>
On 03/12/2012 08:55 PM, Lluís Vilanova wrote:
> Harsh Prateek Bora writes:
>> diff --git a/docs/tracing.txt b/docs/tracing.txt
>> index 95ca16c..ab9048c 100644
>> --- a/docs/tracing.txt
>> +++ b/docs/tracing.txt
>> @@ -39,12 +39,12 @@ generate code for the trace events. Trace events are invoked directly from
>> source code like this:
>
>> #include "trace.h" /* needed for trace event prototype */
>> -
>> +
>> void *qemu_vmalloc(size_t size)
>> {
>> void *ptr;
>> size_t align = QEMU_VMALLOC_ALIGN;
>> -
>> +
>> if (size< align) {
>> align = getpagesize();
>> }
>
> This was not present in my original patch, and will break the display of the
> example when pasted into the wiki.
>
Oh, it looked like blank spaces in git show and therefore I removed,
will revert that.
- Harsh
>
> Lluis
>
next prev parent reply other threads:[~2012-03-14 5:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 13:25 [Qemu-devel] [RFC PATCH v5 00/14] Tracing Improvements, Simpletrace v2 Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 01/14] Converting tracetool.sh to tracetool.py Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 02/14] trace: [tracetool] Do not rebuild event list in backend code Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 03/14] trace: [tracetool] Simplify event line parsing Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 04/14] trace: [tracetool] Do not precompute the event number Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 05/14] trace: [tracetool] Add support for event properties Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 06/14] trace: [tracetool] Process the "disable" event property Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 07/14] trace: [tracetool] Rewrite event argument parsing Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 08/14] trace: [tracetool] Make format-specific code optional with access to events Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 09/14] trace: [tracetool] Automatically establish available backends and formats Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 10/14] trace: Provide a per-event status define for conditional compilation Harsh Prateek Bora
2012-03-12 15:25 ` Lluís Vilanova
2012-03-14 5:25 ` Harsh Bora [this message]
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 11/14] trace: [tracetool] Add error-reporting functions Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 12/14] monitor: remove unused do_info_trace Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 13/14] Simpletrace v2: Handle var num of args, strings Harsh Prateek Bora
2012-03-01 13:25 ` [Qemu-devel] [RFC PATCH v5 14/14] scripts/simpltrace.py changes: Support simplettrace v2 Harsh Prateek Bora
2012-03-13 20:11 ` [Qemu-devel] [RFC PATCH v5 00/14] Tracing Improvements, Simpletrace v2 Lluís Vilanova
2012-03-14 5:36 ` Harsh Bora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F602BE0.60201@linux.vnet.ibm.com \
--to=harsh@linux.vnet.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=vilanova@ac.upc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).