From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41342)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1S7izI-0000Yy-KW
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 03:51:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1S7izG-0002sg-Vd
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 03:51:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34911)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1S7izG-0002sa-Ny
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 03:51:10 -0400
Message-ID: <4F604DE5.1050101@redhat.com>
Date: Wed, 14 Mar 2012 15:51:01 +0800
From: Amos Kong <akong@redhat.com>
MIME-Version: 1.0
References: <20120306224330.24264.9494.stgit@dhcp-8-167.nay.redhat.com>
	<20120306224745.24264.19990.stgit@dhcp-8-167.nay.redhat.com>
	<4F60455C.7090406@redhat.com> <4F60485D.9050209@redhat.com>
In-Reply-To: <4F60485D.9050209@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: aliguori@us.ibm.com, kvm@vger.kernel.org, quintela@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org, Orit Wasserman <owasserm@redhat.com>, laine@redhat.com

On 14/03/12 15:27, Paolo Bonzini wrote:
>

Hi Paolo,

> Il 14/03/2012 08:14, Orit Wasserman ha scritto:
>> if (bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr))<  0)
>> {	
>>      closesocket(*fd);
>>      return -socket_error();
>> }
>> return 0;
>>
>> and than you will not need ret
>
> But closesocket could clobber socket_error(), no?

Yes, it will effect socket_error()

How about this fix ?

     ret = bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr));
     if (ret < 0) {
         ret = -socket_error();
         closesocket(*fd);
     }
     return ret;
}

-- 
			Amos.