From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7jWv-00044o-LO for qemu-devel@nongnu.org; Wed, 14 Mar 2012 04:26:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7jWZ-00018b-9L for qemu-devel@nongnu.org; Wed, 14 Mar 2012 04:25:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62415) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7jWZ-000175-18 for qemu-devel@nongnu.org; Wed, 14 Mar 2012 04:25:35 -0400 Message-ID: <4F6055F9.8000409@redhat.com> Date: Wed, 14 Mar 2012 09:25:29 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1331483977-18910-1-git-send-email-alevy@redhat.com> <1331494004-26177-1-git-send-email-alevy@redhat.com> <1331494004-26177-5-git-send-email-alevy@redhat.com> <20120313103555.0ae4b834@doriath.home> <20120313144514.GK27659@garlic.redhat.com> <20120313125917.2b03a70c@doriath.home> <20120313173524.GO27659@garlic.redhat.com> In-Reply-To: <20120313173524.GO27659@garlic.redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 4/5] console: pass Monitor to vga_hw_screen_dump/hw_vga_dump List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino , qemu-devel@nongnu.org, aliguori@us.ibm.com Hi, > ok, I'll take it. Note that I'm going to not send the qxl screendump > behavior changing patch again, I think all alternatives to a real async > screendump suck, including libvirt changes, and the current behavior of > giving an old screendump is good enough hopefully for the real users, > which are: Agree here. > boxes - refreshing to get updated thumbnails for it's users - will have > 5 seconds old screenshot until async monitor commands land. > autotest - I hope they don't compare image contents (that would be hard > to do), otherwise it's just for logging sake, and so it will lag a > little, too bad. autotest has (used to have?) a install mode where it looked at the screen. I think it isn't used any more these days and unattended install modes (kickstart etc.) of the guests are used instead. But even when checking the screen content it should still work fine, just take a little longer because the screen shots are a bit behind. cheers, Gerd