From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37399) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7jaG-00068t-Kr for qemu-devel@nongnu.org; Wed, 14 Mar 2012 04:29:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7jaF-0001wC-3U for qemu-devel@nongnu.org; Wed, 14 Mar 2012 04:29:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22734) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7jaE-0001vr-Rh for qemu-devel@nongnu.org; Wed, 14 Mar 2012 04:29:23 -0400 Message-ID: <4F6056BF.7050008@redhat.com> Date: Wed, 14 Mar 2012 09:28:47 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20120306224330.24264.9494.stgit@dhcp-8-167.nay.redhat.com> <20120306224745.24264.19990.stgit@dhcp-8-167.nay.redhat.com> <4F60455C.7090406@redhat.com> <4F60485D.9050209@redhat.com> <4F604DE5.1050101@redhat.com> In-Reply-To: <4F604DE5.1050101@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: aliguori@us.ibm.com, kvm@vger.kernel.org, quintela@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org, Orit Wasserman , laine@redhat.com Il 14/03/2012 08:51, Amos Kong ha scritto: > > > ret = bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr)); > if (ret < 0) { > ret = -socket_error(); > closesocket(*fd); > } > return ret; > } Looks good. Paolo