From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47890) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7kMv-00084c-El for qemu-devel@nongnu.org; Wed, 14 Mar 2012 05:19:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7kMq-0005W0-Qc for qemu-devel@nongnu.org; Wed, 14 Mar 2012 05:19:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7kMq-0005Vs-IJ for qemu-devel@nongnu.org; Wed, 14 Mar 2012 05:19:36 -0400 Message-ID: <4F60629B.2030303@redhat.com> Date: Wed, 14 Mar 2012 10:19:23 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1331056563-7503-1-git-send-email-pbonzini@redhat.com> <1331056563-7503-11-git-send-email-pbonzini@redhat.com> <4F5FB28A.4090605@redhat.com> <4F60623B.1090305@redhat.com> In-Reply-To: <4F60623B.1090305@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 10/10] Add the drive-reopen command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: fsimonce@redhat.com, Eric Blake , qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com, lcapitulino@redhat.com Il 14/03/2012 10:17, Kevin Wolf ha scritto: > If we want to do this, it needs to be the same patch, as we couple the > transaction actions with top-level commands as long as there is no other > way to discover the possible actions. And it probably makes more sense > anyway, because the top-level command would be just a thin wrapper > around the transactional one. > > Only problem is that just moving the code there doesn't make it suitable > for a transaction and doing an all-or-nothing drive-reopen isn't quite > trivial. We can also add a "transactionable" item to query-commands. If we do it after 1.1, in absence of it only blockdev-snapshot-sync and drive-mirror are transactionable. Otherwise we can do it now. Paolo