From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48262)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S7kPj-0001BO-Rw
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 05:22:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S7kPi-00060w-6R
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 05:22:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23011)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1S7kPh-00060g-V1
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 05:22:34 -0400
Message-ID: <4F606350.4050807@redhat.com>
Date: Wed, 14 Mar 2012 10:22:24 +0100
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
References: <1331652059-10090-1-git-send-email-marcandre.lureau@redhat.com>
	<1331652059-10090-12-git-send-email-marcandre.lureau@redhat.com>
	<alpine.LNX.2.00.1203131942030.3915@linmac>
In-Reply-To: <alpine.LNX.2.00.1203131942030.3915@linmac>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v4 11/11] audio/rfc: remove PLIVE and
	PERIOD options
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: dnb@redhat.com, Jan Kiszka <jan.kiszka@siemens.com>, dlaor@redhat.com, qemu-devel@nongnu.org, =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= <marcandre.lureau@gmail.com>, =?ISO-8859-1?Q?Marc-Andr=E9_Lureau?= <marcandre.lureau@redhat.com>

On 03/13/12 16:47, malc wrote:
> On Tue, 13 Mar 2012, Marc-Andr? Lureau wrote:
> 
>> - period seems to be unused now

> Period on the other hand is unused because i somehow missed the subtle
> change of behavior in one of the patches made by, i think, Gerd.

Uhm, which patch?  I think that wasn't intentional, at least I can't
remember intentionally disabling period.  Maybe I missed the subtle
change of behavior too.

I do see the point in having this configurable as this is a cpu overhead
vs. latency tradeoff which one might want to tweak depending on the use
case.

If we keep it we should pass it down to the audio backends I think.
pulseaudio for example uses buffer sizes adjusted for the default period
(see qpa_init_out()), when running with a non-default period pulseaudio
should be able to adjust the buffer sizes accordingly.

cheers,
  Gerd