From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37927)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1S7l3v-0005MZ-Mh
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 06:04:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1S7l3Y-00076I-Ox
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 06:04:07 -0400
Received: from mx1.redhat.com ([209.132.183.28]:20775)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <owasserm@redhat.com>) id 1S7l3Y-000768-H4
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 06:03:44 -0400
Message-ID: <4F606CE1.2060401@redhat.com>
Date: Wed, 14 Mar 2012 12:03:13 +0200
From: Orit Wasserman <owasserm@redhat.com>
MIME-Version: 1.0
References: <20120306224330.24264.9494.stgit@dhcp-8-167.nay.redhat.com>
	<20120306224745.24264.19990.stgit@dhcp-8-167.nay.redhat.com>
	<4F60455C.7090406@redhat.com> <4F60485D.9050209@redhat.com>
	<4F604DE5.1050101@redhat.com>
In-Reply-To: <4F604DE5.1050101@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 1/9] net: introduce tcp_server_start()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amos Kong <akong@redhat.com>
Cc: aliguori@us.ibm.com, kvm@vger.kernel.org, quintela@redhat.com, jasowang@redhat.com, qemu-devel@nongnu.org, laine@redhat.com, Paolo Bonzini <pbonzini@redhat.com>

On 03/14/2012 09:51 AM, Amos Kong wrote:
> On 14/03/12 15:27, Paolo Bonzini wrote:
>>
> 
> Hi Paolo,
> 
>> Il 14/03/2012 08:14, Orit Wasserman ha scritto:
>>> if (bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr))<  0)
>>> {   
>>>      closesocket(*fd);
>>>      return -socket_error();
>>> }
>>> return 0;
>>>
>>> and than you will not need ret
>>
>> But closesocket could clobber socket_error(), no?

Completely correct.

> 
> Yes, it will effect socket_error()
> 
> How about this fix ?
> 
>     ret = bind(*fd, (struct sockaddr *)&saddr, sizeof(saddr));
>     if (ret < 0) {
>         ret = -socket_error();
>         closesocket(*fd);
>     }
>     return ret;
> }
> 

Looks good.

Orit