From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:56969)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1S7mXy-0000s6-2U
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 07:39:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1S7mXr-0004pA-Qs
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 07:39:13 -0400
Received: from mx1.redhat.com ([209.132.183.28]:16938)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1S7mXr-0004p2-Ih
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 07:39:07 -0400
Message-ID: <4F60842C.4020107@redhat.com>
Date: Wed, 14 Mar 2012 12:42:36 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <CAJSP0QVeBfWnw+qtw7CiU=A4LE+kNTOMb0B-EWR=aVvqJLRNTQ@mail.gmail.com>
	<00c1eea5-ccb2-4b54-89f8-bdbf00fdc8a4@zmail17.collab.prod.int.phx2.redhat.com>
	<CAJSP0QWpGoaNn_q41sUbsZn8h24hMUHFQV2V6PMr8x6isVso_w@mail.gmail.com>
	<4F5F48F9.7090501@redhat.com>
	<CAJSP0QUJf6tcB2FEBEJg3hLTORmNtc7+v36n6QmppDWRxO1TVQ@mail.gmail.com>
In-Reply-To: <CAJSP0QUJf6tcB2FEBEJg3hLTORmNtc7+v36n6QmppDWRxO1TVQ@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH/RFC 0/7] Screendump to UNIX socket & in PNG
 format
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-devel@nongnu.org, =?ISO-8859-1?Q?Marc-Andr=E9_Lure?= =?ISO-8859-1?Q?au?= <marcandre.lureau@redhat.com>, =?ISO-8859-1?Q?Marc-A?= =?ISO-8859-1?Q?ndr=E9_Lureau?= <mlureau@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>, =?ISO-8859-1?Q?Marc?= =?ISO-8859-1?Q?-Andr=E9_Lureau?= <marcandre.lureau@gmail.com>

Am 14.03.2012 10:42, schrieb Stefan Hajnoczi:
> On Tue, Mar 13, 2012 at 1:17 PM, Gerd Hoffmann <kraxel@redhat.com> wrote:
>>  Hi,
>>
>>> If you want to do it as part of the QEMU codebase then a thread is
>>> probably the best way - it avoids the troubles of forking a
>>> multithreaded program and letting go of resources (guest memory, file
>>> descriptors) that aren't needed across fork.
>>
>> That pretty much requires async monitor command support though, so the
>> iothread can continue driving guest i/o while the new worker thread
>> scales/compresses/writes the screendump.
> 
> The most practical first step would be simply sending the ppm over a
> socket from ppm_save().  The 'screendump' command today already blocks
> so no new badness is being added.  There would be no threads or fancy
> image encoding.

Saving PNGs would be useful even without a management tool.

Kevin