From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54697)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S7nXP-0007T3-EJ
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 08:42:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S7nX0-0003mU-BA
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 08:42:43 -0400
Received: from cantor2.suse.de ([195.135.220.15]:57869 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S7nX0-0003mM-5W
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 08:42:18 -0400
Message-ID: <4F609227.8040605@suse.de>
Date: Wed, 14 Mar 2012 13:42:15 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1330936245-2570-1-git-send-email-i.mitsyanko@samsung.com>
	<1330936245-2570-3-git-send-email-i.mitsyanko@samsung.com>
In-Reply-To: <1330936245-2570-3-git-send-email-i.mitsyanko@samsung.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH V2 2/5] hw/pxa2xx_dma.c: drop
 target_phys_addr_t usage in device state
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mitsyanko <i.mitsyanko@samsung.com>
Cc: peter.maydell@linaro.org, balrog@zabor.org, e.voevodin@samsung.com, quintela@redhat.com, qemu-devel@nongnu.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, m.kozlov@samsung.com

Am 05.03.2012 09:30, schrieb Igor Mitsyanko:
> Pxa2xx DMA controller is a 32-bit device and it has no knowledge of sys=
tem's
> physical address size, so it should not use target_phys_addr_t in it's =
state.
> Convert variables descr, src and dest from type target_phys_addr_t to u=
int32_t,
> use VMSTATE_UINT32 instead of VMSTATE_UINTTL for these variables.
>=20
> We can do this safely because:
> 1) pxa2xx actually has 32-bit physical address size;

> 2) rest of the code in file never assumes descr, src and dest variables=
 to have
> size different from uint32_t;
> 3) we shouldn't have used VMSTATE_UINTTL in the first place because thi=
s macro
> is for target_ulong type (which can be different from target_phys_addr_=
t).

Agreed.

> Signed-off-by: Igor Mitsyanko <i.mitsyanko@samsung.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg