From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7nd8-0001e4-Vy for qemu-devel@nongnu.org; Wed, 14 Mar 2012 08:48:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7nch-0004qE-5n for qemu-devel@nongnu.org; Wed, 14 Mar 2012 08:48:38 -0400 Received: from cantor2.suse.de ([195.135.220.15]:58062 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7nch-0004q0-0R for qemu-devel@nongnu.org; Wed, 14 Mar 2012 08:48:11 -0400 Message-ID: <4F609388.6000809@suse.de> Date: Wed, 14 Mar 2012 13:48:08 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1330936245-2570-1-git-send-email-i.mitsyanko@samsung.com> <1330936245-2570-4-git-send-email-i.mitsyanko@samsung.com> In-Reply-To: <1330936245-2570-4-git-send-email-i.mitsyanko@samsung.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V2 3/5] hw/pxa2xx_lcd.c: drop target_phys_addr_t usage in device state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mitsyanko Cc: peter.maydell@linaro.org, e.voevodin@samsung.com, quintela@redhat.com, qemu-devel@nongnu.org, kyungmin.park@samsung.com, d.solodkiy@samsung.com, m.kozlov@samsung.com Am 05.03.2012 09:30, schrieb Igor Mitsyanko: > Pxa2xx LCD controller is intended to work with 32-bit bus and it has no= knowledge > of system's physical address size, so it should not use target_phys_add= r_t in it's > state. Convert three variables in DMAChannel state from target_phys_add= r_t to uint32_t, > use VMSTATE_UINT32 instead of VMSTATE_UINTTL for these variables. > We can do this safely because: > 1) pxa2xx has 32-bit physical address; > 2) rest of the code in file never assumes converted variables to have a= ny size > different from uint32_t; > 3) we shouldn't have used VMSTATE_UINTTL in the first place because thi= s macro > is for target_ulong type (which can be different from target_phys_addr_= t). >=20 > Signed-off-by: Igor Mitsyanko > Reviewed-by: Peter Maydell Reviewed-by: Andreas F=E4rber Some Coccinelle script or so to verify that also non-UINTTL fields match types would probably be nice long-term. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg