From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52682) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7oHr-00089S-ER for qemu-devel@nongnu.org; Wed, 14 Mar 2012 09:30:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7oHV-0006LZ-62 for qemu-devel@nongnu.org; Wed, 14 Mar 2012 09:30:43 -0400 Message-ID: <4F609D67.10809@suse.de> Date: Wed, 14 Mar 2012 14:30:15 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1331169142-13325-1-git-send-email-david@gibson.dropbear.id.au> <1331169142-13325-3-git-send-email-david@gibson.dropbear.id.au> <1F2D3177-F622-41D6-8519-1D907A20E87D@suse.de> <20120313035024.GH24916@truffala.fritz.box> In-Reply-To: <20120313035024.GH24916@truffala.fritz.box> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] pseries: Configure PCI bridge using properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf , David Gibson Cc: Alexey Kardashevskiy , qemu-ppc@nongnu.org, "qemu-devel@nongnu.org Developers" Am 13.03.2012 04:50, schrieb David Gibson: > On Sat, Mar 10, 2012 at 11:40:41PM +0100, Alexander Graf wrote: >> >> On 08.03.2012, at 02:12, David Gibson wrote: >> >>> Currently, the function spapr_create_phb() uses its parameters to >>> initialize the correct memory windows for the new PCI Host Bridge >>> (PHB). This is not the way things are supposed to be done with qdevs= , >>> and means you can't create extra PHBs easily using -device. >>> >>> Since pSeries machines can and do have many PHBs with various >>> configurations, this is a real limitation, not just a theoretical. >>> This patch, therefore, alters the PHB initialization code to use qdev >>> properties to set these parameters of the new bridge, moving most of >>> the code from spapr_create_phb() to spapr_phb_init(). >>> >>> While we're at it, we change the naming of each PCI bus and its >>> associated memory regions to be less arbitrary and make it easier to >>> relate the guest and qemu views of memory to each other. >>> >>> Signed-off-by: Alexey Kardashevskiy >>> Signed-off-by: David Gibson >> >> Andreas, could you please (n)ack this version? >=20 > Actually, can you review and merge this updated version instead. > Turns out that libvirt and some other tools assume that there will be > a PCI bus named simply "pci", which is no longer true with the patch > above (we call each bus "pci@XXXXXX" to match the guest's device > tree). The revised version calls the default bus simply "pci" to work > around libvirt's PC centrism, and allows manually added extra busses > to be named explicitly with a property, defaulting to "pci@XXXXX". I was happy with David's improvements but didn't feel comfortable acking the overall patch. Reviewed-by: Andreas F=E4rber One minor improvement in case this gets gespun: * spapr_phb_info could be made static const (was/is static) Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg