From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41939)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S7oMW-0004AL-6a
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 09:35:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S7oMP-0007KR-I7
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 09:35:31 -0400
Received: from cantor2.suse.de ([195.135.220.15]:33083 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S7oMP-0007KK-Bl
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 09:35:25 -0400
Message-ID: <4F609E9B.6000207@suse.de>
Date: Wed, 14 Mar 2012 14:35:23 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1331707448-3880-1-git-send-email-sw@weilnetz.de>
In-Reply-To: <1331707448-3880-1-git-send-email-sw@weilnetz.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3] w32: Support tests (make check)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

Am 14.03.2012 07:44, schrieb Stefan Weil:
> Adding $(EXESUF) is needed to make those tests work on w32 hosts, too.
>=20
> v2:
> Rebased, added new tests, tests sorted alphabetically.
>=20
> v3:
> Rebased, $(EXESUF) for qemu-img, qemu-io which were recently added.
>=20
> Cc: Anthony Liguori <aliguori@us.ibm.com>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Andreas F=C3=A4rber <afaerber@suse.de>
> Reviewed-by: Andreas F=C3=A4rber <afaerber@suse.de>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>=20
> This is the 3rd version of my patch. The 1st was sent in February,
> and since then some other newer (!) patches were committed,
> so I had to rebase my patch two times.
[...]
> Andreas, I added your reviewed-by from v2. v3 includes additional
> changes, so could you please check that the reviewed-by is still valid?

Apart from what Kevin pointed out, adding $(EXESUF) and shortening the
lines still looks good to me, so in case you want this as an
intermediate step,

Reviewed-by: Andreas F=C3=A4rber <afaerber@suse.de>

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg