Re: [Qemu-devel] We need more reviewers/maintainers!!

["Andreas Färber" <afaerber@suse.de>]

Am 14.03.2012 15:17, schrieb Anthony Liguori:
> On 03/14/2012 08:58 AM, Peter Maydell wrote:
>> On 14 March 2012 13:52, Anthony Liguori<anthony@codemonkey.ws>  wrote:
>>> On 03/14/2012 08:50 AM, Andreas Färber wrote:
>>>> What I have wondered is, is there any semantic difference between
>>>> "Ack",
>>>> "Acked", "ACK" and "Acked-by: name<email>"? I.e., when someone replies
>>>> with "Ack", should one document that as an Acked-by for a PULL?
>>>
>>>
>>> No, Acked-by: name<email>  is a formal statement.  You shouldn't
>>> infer an
>>> Acked-by IMHO.
>>
>> This is in contradiction to the kernel docs we reference, which say:
>> # Acked-by: is not as formal as Signed-off-by:.  It is a record that
>> the acker
>> # has at least reviewed the patch and has indicated acceptance.  Hence
>> patch
>> # mergers will sometimes manually convert an acker's "yep, looks good
>> to me"
>> # into an Acked-by:.
> 
> Oh, I guess I stand corrected.  It would certainly surprise me if
> someone added my Acked-by without asking me but maybe this is just
> American politeness...

And seeing what politeness got us into yesterday I'm asking... ;-)

I was surprised by the relicensing how-to btw that instructed to add
people's SoB - I usually tend to think that agreeing on how to go about
something and seeing how it was actually done would be separate issues.
But then again the SoBs get cc'ed so have a chance to object.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg