From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43528) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7p9d-000119-O7 for qemu-devel@nongnu.org; Wed, 14 Mar 2012 10:26:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7p9E-0005tN-UR for qemu-devel@nongnu.org; Wed, 14 Mar 2012 10:26:17 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37106 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7p9E-0005tI-LC for qemu-devel@nongnu.org; Wed, 14 Mar 2012 10:25:52 -0400 Message-ID: <4F60AA6F.8070908@suse.de> Date: Wed, 14 Mar 2012 15:25:51 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <87wr6pwvas.fsf@ginnungagap.bsc.es> <4F5F4B4F.3070003@redhat.com> <4F60A20B.2020108@suse.de> <4F60A292.1060307@codemonkey.ws> <4F60A866.2050304@codemonkey.ws> In-Reply-To: <4F60A866.2050304@codemonkey.ws> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] We need more reviewers/maintainers!! List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: =?UTF-8?B?TGx1w61zIFZpbGFub3Zh?= , Peter Maydell , Stefano Stabellini , "qemu-devel@nongnu.org" , Avi Kivity Am 14.03.2012 15:17, schrieb Anthony Liguori: > On 03/14/2012 08:58 AM, Peter Maydell wrote: >> On 14 March 2012 13:52, Anthony Liguori wrote: >>> On 03/14/2012 08:50 AM, Andreas F=C3=A4rber wrote: >>>> What I have wondered is, is there any semantic difference between >>>> "Ack", >>>> "Acked", "ACK" and "Acked-by: name"? I.e., when someone repli= es >>>> with "Ack", should one document that as an Acked-by for a PULL? >>> >>> >>> No, Acked-by: name is a formal statement. You shouldn't >>> infer an >>> Acked-by IMHO. >> >> This is in contradiction to the kernel docs we reference, which say: >> # Acked-by: is not as formal as Signed-off-by:. It is a record that >> the acker >> # has at least reviewed the patch and has indicated acceptance. Hence >> patch >> # mergers will sometimes manually convert an acker's "yep, looks good >> to me" >> # into an Acked-by:. >=20 > Oh, I guess I stand corrected. It would certainly surprise me if > someone added my Acked-by without asking me but maybe this is just > American politeness... And seeing what politeness got us into yesterday I'm asking... ;-) I was surprised by the relicensing how-to btw that instructed to add people's SoB - I usually tend to think that agreeing on how to go about something and seeing how it was actually done would be separate issues. But then again the SoBs get cc'ed so have a chance to object. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg