From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:49872)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S7qZt-0002pz-Rw
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 11:57:34 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S7qZl-0000yp-O2
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 11:57:29 -0400
Received: from mail-yx0-f173.google.com ([209.85.213.173]:45806)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S7qZl-0000yR-Jt
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 11:57:21 -0400
Received: by yenr5 with SMTP id r5so2243251yen.4
	for <qemu-devel@nongnu.org>; Wed, 14 Mar 2012 08:57:20 -0700 (PDT)
Message-ID: <4F60BFDB.40302@codemonkey.ws>
Date: Wed, 14 Mar 2012 10:57:15 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <4F3CFBBB.5020600@codemonkey.ws> <4F5F141F.8080202@cn.fujitsu.com>
	<4F5F29CE.70806@suse.de> <4F604FF9.8010403@cn.fujitsu.com>
	<4F6058BE.4060403@redhat.com>
	<20120314134959.GC14227@dhcp-192-168-178-175.profitbricks.localdomain>
	<20120314152324.GF2304@redhat.com> <4F60BA15.90506@codemonkey.ws>
	<20120314153529.GG2304@redhat.com> <4F60BC7A.9000504@codemonkey.ws>
	<20120314155409.GI2304@redhat.com>
In-Reply-To: <20120314155409.GI2304@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gleb Natapov <gleb@redhat.com>
Cc: Lai Jiangshan <laijs@cn.fujitsu.com>, Jan Kiszka <jan.kiszka@siemens.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>, Igor Mammedov <imammedo@redhat.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>

On 03/14/2012 10:54 AM, Gleb Natapov wrote:
> On Wed, Mar 14, 2012 at 10:42:50AM -0500, Anthony Liguori wrote:
>>
>> There's still a few places in QEMU that assume that
>> qemu_ram_get_ptr() returns a pointer that's good indefinitely.
>>
>> We also don't have a mechanism to revoke cpu_physical_map()
>> pointers.  Maybe the answer is reference counting and relying on
>> being able to eventually release the memory...   Of course, then an
>> unplug followed by an immediate plug would be complicated.
>>
> Hmm, Avi assured me that with the memory API rework it should be easy :(
> grep founds nothing about qemu_ram_get_ptr() and cpu_physical_map()
> though. What should I look for?

memory_region_get_ptr() and cpu_memory_physical_map().

Regards,

Anthony Liguori