From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47147) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7s9N-0002is-AT for qemu-devel@nongnu.org; Wed, 14 Mar 2012 13:38:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7s91-0007I6-RQ for qemu-devel@nongnu.org; Wed, 14 Mar 2012 13:38:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7s91-0007H9-JF for qemu-devel@nongnu.org; Wed, 14 Mar 2012 13:37:51 -0400 Message-ID: <4F60D766.1020106@redhat.com> Date: Wed, 14 Mar 2012 11:37:42 -0600 From: Eric Blake MIME-Version: 1.0 References: <4F5FFC63.3060300@cn.fujitsu.com> <20120314142648.6b0805dc@doriath.home> In-Reply-To: <20120314142648.6b0805dc@doriath.home> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig9E168C6AAED06EE3A8B4A99D" Subject: Re: [Qemu-devel] [RFC][PATCH 00/14 v9] introducing a new, dedicated memory dump mechanism List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Jan Kiszka , qemu-devel , HATAYAMA Daisuke , Dave Anderson , Anthony Liguori This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9E168C6AAED06EE3A8B4A99D Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 03/14/2012 11:26 AM, Luiz Capitulino wrote: > On Wed, 14 Mar 2012 10:03:15 +0800 > Wen Congyang wrote: >=20 >> Changes from v8 to v9: >> 1. remove async support(it will be reimplemented after QAPI async comm= ands support >> is finished) >=20 > I gave my review on this one (concentrating on the QMP part only), and = one > important aspect of this command is that it's a long synchronous operat= ion. >=20 > As it runs with vCPUs stopped, the only drawback is that libvirt won't = be able > to run other commands in parallel and won't be able to cancel it either= =2E Also > note that this command is most likely to be executed when the guest cra= shes. >=20 > Given all this, it's fine with me to have this as a synchronous command= , but > I'd like to get an ACK from libvirt and another one from Jan and/or Ant= hony. The inability to cancel is annoying (which is why I first suggested that we add async handling and cancel back in v2 or so); but your arguments th= at: 1. async support will be coming in qemu 1.2, and polluting the waters with ad-hoc async stuff in 1.1 will just make it harder 2. dump typically only gets run when a guest will no longer be running, therefore having it be blocking is not the end of the world, as long as the user doesn't mind the inability to cancel are sufficient that I'm okay with a synchronous-only version for qemu 1.1. It won't be the first time libvirt has had a long-running command it couldn't cancel (think 'savevm', for instance). --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig9E168C6AAED06EE3A8B4A99D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJPYNdnAAoJEKeha0olJ0NqtZIIAI5zNott0zaiBbA7/k9UbR0K KdVz0M71lOAzCufDq/j7yiZKBvzoAeGCICmVNzsSTVAevRFUozhLwlzzXVFv/O8b AcrWSUngKVFSCgBgKOCFwBDMtapTRnl6NQ7JMWS5xoAFGP9zmi2FLEQNcxfy+ybL LX1dpMoZH366ZPfCv264BayAFnxdOspetwcBXy3jPLqv4P4ajd3TNeqV3Fq0HZex DFEC4BbGlSgY4bkBb/ZtzNDS7mln0MFsks4hJ5u/7RnzlikhI8bonL6+S8jKthDn GXhNktI7eN+RDxDnxy5WIlF3iVw8VPAKuFmpp/alclnJihanVHvDPXhDLUljzqY= =dXuh -----END PGP SIGNATURE----- --------------enig9E168C6AAED06EE3A8B4A99D--