From: Anthony Liguori <anthony@codemonkey.ws>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel <qemu-devel@nongnu.org>,
HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>,
Dave Anderson <anderson@redhat.com>,
Eric Blake <eblake@redhat.com>
Subject: Re: [Qemu-devel] [RFC][PATCH 00/14 v9] introducing a new, dedicated memory dump mechanism
Date: Wed, 14 Mar 2012 12:49:59 -0500 [thread overview]
Message-ID: <4F60DA47.50901@codemonkey.ws> (raw)
In-Reply-To: <20120314142648.6b0805dc@doriath.home>
On 03/14/2012 12:26 PM, Luiz Capitulino wrote:
> On Wed, 14 Mar 2012 10:03:15 +0800
> Wen Congyang<wency@cn.fujitsu.com> wrote:
>
>> Changes from v8 to v9:
>> 1. remove async support(it will be reimplemented after QAPI async commands support
>> is finished)
>
> I gave my review on this one (concentrating on the QMP part only), and one
> important aspect of this command is that it's a long synchronous operation.
>
> As it runs with vCPUs stopped, the only drawback is that libvirt won't be able
> to run other commands in parallel and won't be able to cancel it either. Also
> note that this command is most likely to be executed when the guest crashes.
>
> Given all this, it's fine with me to have this as a synchronous command, but
> I'd like to get an ACK from libvirt and another one from Jan and/or Anthony.
Just a general comment.
Why is this an RFC if it's at v9? RFC's are never added to my review queue so I
haven't looked at this series at all.
Can we start by posting a non-RFC because we start discussing committing this.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2012-03-14 17:50 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-14 2:03 [Qemu-devel] [RFC][PATCH 00/14 v9] introducing a new, dedicated memory dump mechanism Wen Congyang
2012-03-14 2:05 ` [Qemu-devel] [RFC][PATCH 01/14 v9] Add API to create memory mapping list Wen Congyang
2012-03-14 2:06 ` [Qemu-devel] [RFC][PATCH 02/14 v9] Add API to check whether a physical address is I/O address Wen Congyang
2012-03-14 9:18 ` [Qemu-devel] [RESEND][PATCH " Wen Congyang
2012-03-14 2:06 ` [Qemu-devel] [RFC][PATCH 03/14 v9] implement cpu_get_memory_mapping() Wen Congyang
2012-03-14 2:07 ` [Qemu-devel] [RFC][PATCH 04/14 v9] Add API to check whether paging mode is enabled Wen Congyang
2012-03-14 2:07 ` [Qemu-devel] [RFC][PATCH 05/14 v9] Add API to get memory mapping Wen Congyang
2012-03-16 3:52 ` HATAYAMA Daisuke
2012-03-16 6:50 ` Wen Congyang
2012-03-16 6:38 ` HATAYAMA Daisuke
2012-03-16 6:59 ` Wen Congyang
2012-03-14 2:08 ` [Qemu-devel] [RFC][PATCH 06/14 v9] Add API to get memory mapping without do paging Wen Congyang
2012-03-14 2:08 ` [Qemu-devel] [RFC][PATCH 07/14 v9] target-i386: Add API to write elf notes to core file Wen Congyang
2012-03-16 1:17 ` HATAYAMA Daisuke
2012-03-14 2:09 ` [Qemu-devel] [RFC][PATCH 08/14 v9] target-i386: Add API to write cpu status " Wen Congyang
2012-03-16 1:48 ` HATAYAMA Daisuke
2012-03-16 6:50 ` Wen Congyang
2012-03-19 1:09 ` HATAYAMA Daisuke
2012-03-14 2:09 ` [Qemu-devel] [RFC][PATCH 09/14 v9] target-i386: add API to get dump info Wen Congyang
2012-03-14 2:10 ` [Qemu-devel] [RFC][PATCH 10/14 v9] make gdb_id() generally avialable Wen Congyang
2012-03-14 2:11 ` [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory Wen Congyang
2012-03-14 17:18 ` Luiz Capitulino
2012-03-15 2:29 ` Wen Congyang
2012-03-15 14:25 ` Luiz Capitulino
2012-03-16 10:13 ` Wen Congyang
2012-03-19 2:28 ` Wen Congyang
2012-03-19 8:31 ` Wen Congyang
2012-03-19 13:16 ` Luiz Capitulino
2012-03-16 3:23 ` HATAYAMA Daisuke
2012-03-16 6:41 ` Wen Congyang
2012-03-14 2:12 ` [Qemu-devel] [RFC][PATCH 12/14 v9] support to cancel the current dumping Wen Congyang
2012-03-14 17:19 ` Luiz Capitulino
2012-03-14 2:13 ` [Qemu-devel] [RFC][PATCH 13/14 v9] support to query dumping status Wen Congyang
2012-03-14 17:19 ` Luiz Capitulino
2012-03-14 2:13 ` [Qemu-devel] [RFC][PATCH 14/14 v9] allow user to dump a fraction of the memory Wen Congyang
2012-03-14 17:20 ` Luiz Capitulino
2012-03-14 17:26 ` [Qemu-devel] [RFC][PATCH 00/14 v9] introducing a new, dedicated memory dump mechanism Luiz Capitulino
2012-03-14 17:37 ` Eric Blake
2012-03-14 17:49 ` Anthony Liguori [this message]
2012-03-14 18:03 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F60DA47.50901@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=anderson@redhat.com \
--cc=d.hatayama@jp.fujitsu.com \
--cc=eblake@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).