From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45279)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S7sL3-0003Qp-70
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 13:50:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S7sKw-0002Db-GX
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 13:50:16 -0400
Received: from mail-pz0-f47.google.com ([209.85.210.47]:55168)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S7sKw-0002DS-9x
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 13:50:10 -0400
Received: by dado14 with SMTP id o14so3473779dad.34
	for <qemu-devel@nongnu.org>; Wed, 14 Mar 2012 10:50:08 -0700 (PDT)
Message-ID: <4F60DA47.50901@codemonkey.ws>
Date: Wed, 14 Mar 2012 12:49:59 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <4F5FFC63.3060300@cn.fujitsu.com>
	<20120314142648.6b0805dc@doriath.home>
In-Reply-To: <20120314142648.6b0805dc@doriath.home>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC][PATCH 00/14 v9] introducing a new,
 dedicated memory dump mechanism
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel <qemu-devel@nongnu.org>, HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>, Dave Anderson <anderson@redhat.com>, Eric Blake <eblake@redhat.com>

On 03/14/2012 12:26 PM, Luiz Capitulino wrote:
> On Wed, 14 Mar 2012 10:03:15 +0800
> Wen Congyang<wency@cn.fujitsu.com>  wrote:
>
>> Changes from v8 to v9:
>> 1. remove async support(it will be reimplemented after QAPI async commands support
>>     is finished)
>
> I gave my review on this one (concentrating on the QMP part only), and one
> important aspect of this command is that it's a long synchronous operation.
>
> As it runs with vCPUs stopped, the only drawback is that libvirt won't be able
> to run other commands in parallel and won't be able to cancel it either. Also
> note that this command is most likely to be executed when the guest crashes.
>
> Given all this, it's fine with me to have this as a synchronous command, but
> I'd like to get an ACK from libvirt and another one from Jan and/or Anthony.

Just a general comment.

Why is this an RFC if it's at v9?  RFC's are never added to my review queue so I 
haven't looked at this series at all.

Can we start by posting a non-RFC because we start discussing committing this.

Regards,

Anthony Liguori