From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47157) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7tnX-0000lj-2a for qemu-devel@nongnu.org; Wed, 14 Mar 2012 15:23:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S7tn8-000770-HY for qemu-devel@nongnu.org; Wed, 14 Mar 2012 15:23:46 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:59253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S7tn8-00076V-D1 for qemu-devel@nongnu.org; Wed, 14 Mar 2012 15:23:22 -0400 Received: by yenr5 with SMTP id r5so2500013yen.4 for ; Wed, 14 Mar 2012 12:23:20 -0700 (PDT) Message-ID: <4F60F023.2060307@codemonkey.ws> Date: Wed, 14 Mar 2012 14:23:15 -0500 From: Anthony Liguori MIME-Version: 1.0 References: <20585aca-cce1-4305-9ef8-69e51321930c@zmail17.collab.prod.int.phx2.redhat.com> <20120314085310.GA4042@lws.brq.redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2] Man page: Add -global description List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Miroslav Rezanina , qemu-devel@nongnu.org On 03/14/2012 01:21 PM, Peter Maydell wrote: > On 14 March 2012 08:53, Miroslav Rezanina wrote: >> --- a/qemu-options.hx >> +++ b/qemu-options.hx >> @@ -292,9 +292,13 @@ DEF("global", HAS_ARG, QEMU_OPTION_global, >> " set a global default for a driver property\n", >> QEMU_ARCH_ALL) >> STEXI >> -@item -global >> +@item -global @var{driver}.@var{property}=@var{value} > > We seem to use @var{prop}, not @var{property}, elsewhere in the docs. > >> @findex -global >> -TODO >> +Set default value of @var{driver}'s @var{property} to @var{value}, e.g.: >> + >> +@example >> +qemu -global ide-drive.physical_block_size=4096 -drive file=file,if=ide,index=0 >> +@end example >> ETEXI > > This is missing any motivation for why you would want to actually > use this option. How about: > > "In particular, you can use this to set driver properties for devices which > are created automatically by the machine model. (To create a device which is > not created automatically and set properties on it, use -device.)" > > ? > > That's still not great, but I think it helps a little. > > (ideally if -device/-global are the new standard interface we should have a > section explaining the general concepts and syntax and then documentation of > how to do specific things like networking via -device, and relegate all the > 'legacy' options to a section clearly marked as 'legacy' with pointers back > to the new ways of doing the same thing. That would be a much bigger job, > though.) Just while we're here, I'll be posting the following shortly: commit 82aff428155d469ab705294486cc26cb34947999 Author: Anthony Liguori Date: Fri Dec 23 11:30:45 2011 -0600 qdev: don't allow globals to be set by bus name This is technically a compatibility breaker. However: 1) libvirt does not rely on this (it always uses the driver name) 2) This behavior isn't actually documented anywhere (the docs just say driver). 3) I suspect there are less than three people on earth that even know this is possible (minus the people reading this message). So I think we can safely break it :-) Signed-off-by: Anthony Liguori Regards, Anthony Liguori > > -- PMM >