From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:46695)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S7uwh-0004Kp-Fj
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 16:37:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S7uwf-0007nW-2G
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 16:37:19 -0400
Received: from cantor2.suse.de ([195.135.220.15]:60429 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S7uwe-0007n9-Rp
	for qemu-devel@nongnu.org; Wed, 14 Mar 2012 16:37:16 -0400
Message-ID: <4F610179.1000004@suse.de>
Date: Wed, 14 Mar 2012 21:37:13 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1330893156-26569-1-git-send-email-afaerber@suse.de>
	<1331346496-10736-1-git-send-email-afaerber@suse.de>
	<1331346496-10736-45-git-send-email-afaerber@suse.de>
	<4F5DC41F.10903@redhat.com> <4F5F39DD.5040308@suse.de>
	<4F61017F.5020301@gmail.com>
In-Reply-To: <4F61017F.5020301@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH RFC v4 44/44] qom: Introduce CPU class
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: i.mitsyanko@samsung.com
Cc: Igor Mitsyanko <i.mitsyanko@gmail.com>, qemu-devel@nongnu.org, d.solodkiy@samsung.com, Anthony Liguori <anthony@codemonkey.ws>, Paolo Bonzini <pbonzini@redhat.com>, Igor Mammedov <imammedo@redhat.com>

Am 14.03.2012 21:37, schrieb Igor Mitsyanko:
> On 13.03.2012 3:13 PM, Andreas F=C3=A4rber wrote:
>=20
>> I never heard anyone wanting to generalize reset so far. I don't think
>> it belongs into Object at least. Maybe DeviceState. Anthony? Paolo?
>>
>=20
> We can have a special object for this, let's call it ResetLine for
> example, with methods ResetLine::connect, ResetLine::assert or somethin=
g
> like that. Different ResetLine objects could trigger reset of different
> sets of subdevices, just like real hardware can have several reset type=
s
> (for example, STM32 has 3 different reset types).

Anthony provided a Reviewed-by, and given that this is a direct
conversion of cpu_reset() -> cpu_state_reset() -> CPUState::reset(), I
am preparing a PULL for this series tonight. That does not mean that the
code must stay like this forever. :)

cpu_reset() only handles the full reset of one CPU, as I understand, and
is called both at startup and at machine-level reset.

Anthony's Pin object, as qemu_irq successor, was planned post-4th QOM
series, I believe. -- "Small steps, Allie."

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg