From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40847) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S87P4-0005nh-K8 for qemu-devel@nongnu.org; Thu, 15 Mar 2012 05:55:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S87Oy-0007IZ-Fg for qemu-devel@nongnu.org; Thu, 15 Mar 2012 05:55:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S87Oy-0007IN-7n for qemu-devel@nongnu.org; Thu, 15 Mar 2012 05:55:20 -0400 Message-ID: <4F61BC83.2010700@redhat.com> Date: Thu, 15 Mar 2012 11:55:15 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1331049010-24312-1-git-send-email-avi@redhat.com> <4F61008B.4070007@codemonkey.ws> In-Reply-To: <4F61008B.4070007@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] kvmvapic: align start address as well as size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Jan Kiszka , qemu-devel@nongnu.org On 03/14/2012 10:33 PM, Anthony Liguori wrote: > On 03/06/2012 09:50 AM, Avi Kivity wrote: >> The kvmvapic code remaps a section of ROM as RAM to allow the guest to >> maintain state there. It is careful to align the section size to a page >> boundary, to avoid creating subpages, but neglects to do the same for >> the start address. These leads to an assert later on when the memory >> core tries to create a page which is half RAM and half ROM. >> >> Fix by aligning the start address to a page boundary. >> >> This can be triggered by running qemu-system-x86_64 -enable-kvm -vga >> none. >> >> Signed-off-by: Avi Kivity > > Tested-by: Anthony Liguori > > Are you going to do a PULL request or do you want me to apply directly? I forgot all about it, sorry. -- error compiling committee.c: too many arguments to function