From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52978)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S8AXo-00020X-EU
	for qemu-devel@nongnu.org; Thu, 15 Mar 2012 09:16:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S8AXm-0006pV-Nv
	for qemu-devel@nongnu.org; Thu, 15 Mar 2012 09:16:40 -0400
Received: from mail-pz0-f47.google.com ([209.85.210.47]:34285)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1S8AXm-0006pB-HC
	for qemu-devel@nongnu.org; Thu, 15 Mar 2012 09:16:38 -0400
Received: by dado14 with SMTP id o14so5204143dad.34
	for <qemu-devel@nongnu.org>; Thu, 15 Mar 2012 06:16:36 -0700 (PDT)
Message-ID: <4F61EBAF.70608@codemonkey.ws>
Date: Thu, 15 Mar 2012 08:16:31 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1331049010-24312-1-git-send-email-avi@redhat.com>
	<4F61008B.4070007@codemonkey.ws> <4F61BC83.2010700@redhat.com>
In-Reply-To: <4F61BC83.2010700@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] kvmvapic: align start address as well as
 size
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org

On 03/15/2012 04:55 AM, Avi Kivity wrote:
> On 03/14/2012 10:33 PM, Anthony Liguori wrote:
>> On 03/06/2012 09:50 AM, Avi Kivity wrote:
>>> The kvmvapic code remaps a section of ROM as RAM to allow the guest to
>>> maintain state there.  It is careful to align the section size to a page
>>> boundary, to avoid creating subpages, but neglects to do the same for
>>> the start address.  These leads to an assert later on when the memory
>>> core tries to create a page which is half RAM and half ROM.
>>>
>>> Fix by aligning the start address to a page boundary.
>>>
>>> This can be triggered by running qemu-system-x86_64 -enable-kvm -vga
>>> none.
>>>
>>> Signed-off-by: Avi Kivity<avi@redhat.com>
>>
>> Tested-by: Anthony Liguori<aliguori@us.ibm.com>
>>
>> Are you going to do a PULL request or do you want me to apply directly?
>
> I forgot all about it, sorry.

No worries.  I actually caught the bug in the original pull request but do to a 
bug in qemu-test, when I tried to bisect, things got weird and I mistakenly 
thought the real problem had been introduced earlier.

Regards,

Anthony Liguori

>