From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8Cou-0003Cf-6Y for qemu-devel@nongnu.org; Thu, 15 Mar 2012 11:42:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S8Con-0002nI-BH for qemu-devel@nongnu.org; Thu, 15 Mar 2012 11:42:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:63395) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8Con-0002mq-3B for qemu-devel@nongnu.org; Thu, 15 Mar 2012 11:42:21 -0400 Message-ID: <4F620DD6.5080807@redhat.com> Date: Thu, 15 Mar 2012 17:42:14 +0200 From: Avi Kivity MIME-Version: 1.0 References: <20120315143015.6381.14579.stgit@x201> <20120315143029.6381.43316.stgit@x201> <4F6208A2.7090700@redhat.com> <4F620B68.9080701@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 3/3] Minimal ARM LPAE support. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, Alexey Starikovskiy On 03/15/2012 05:37 PM, Peter Maydell wrote: > On 15 March 2012 15:31, Avi Kivity wrote: > > On 03/15/2012 05:24 PM, Peter Maydell wrote: > >> On 15 March 2012 15:20, Avi Kivity wrote: > >> > Please add code that detects the use of unimplemented features and > >> > aborts > >> > >> I'm not a great fan of letting the guest cause QEMU to abort... > > > > Why not? It (the guest) is going to malfunction anyway. > > It would be cleaner to cause the guest to take an exception > IMHO. (This is typically what ought to happen anyway if the > guest accesses an unimplemented cp15 register, although our > current mess has a habit of underdecoding these things.) At the very least, print something out so it's clear that qemu may be at fault, not the guest. This is what kvm does in such cases (which we discourage, but still exist). -- error compiling committee.c: too many arguments to function