From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8Et7-0005ya-Er for qemu-devel@nongnu.org; Thu, 15 Mar 2012 13:54:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S8Et2-0007F8-MY for qemu-devel@nongnu.org; Thu, 15 Mar 2012 13:54:57 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48655 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8Et2-0007EY-GH for qemu-devel@nongnu.org; Thu, 15 Mar 2012 13:54:52 -0400 Message-ID: <4F622CE4.5030401@suse.de> Date: Thu, 15 Mar 2012 18:54:44 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1331833785-9377-1-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1331833785-9377-1-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] gdbserver: Don't send a GDB syscall until the system CPU is stopped List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Anthony Liguori , Meador Inge , qemu-devel@nongnu.org, Paul Brook Am 15.03.2012 18:49, schrieb Peter Maydell: > From: Meador Inge >=20 > Fix an issue where the GDB server implementation was sending GDB syscal= l > requests while the system CPU was still running. Syscall requests must > be sent while the CPU is stopped otherwise replies from the GDB client > might get dropped and the GDB server might be incorrectly transitioned > into a 'RUN_STATE_PAUSED' state. >=20 > Signed-off-by: Meador Inge > [PMM: trivial rebase, reinstated comma after last item in RSState enum] > Signed-off-by: Peter Maydell Reviewed-by: Andreas F=E4rber > --- > This patch got (trivially) busted by Andreas' commits changing > CPUState to CPUArchState so I've rebased and resent it. I've also > made the trivial style nit fix of not deleting the final comma in > the RSState enum, based on conversation with Andreas in IRC. Thanks, Peter! Andreas > This patch has sitting on the list for about a month reviewed but > unapplied (http://patchwork.ozlabs.org/patch/141867/) -- can > somebody with commit rights apply it please? >=20 > gdbstub.c | 42 +++++++++++++++++++++++++++--------------- > 1 files changed, 27 insertions(+), 15 deletions(-) --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg