From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47190)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1S8IDT-0005kE-Mu
	for qemu-devel@nongnu.org; Thu, 15 Mar 2012 17:28:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1S8IDR-0005OU-Q3
	for qemu-devel@nongnu.org; Thu, 15 Mar 2012 17:28:11 -0400
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:34976)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1S8IDR-0005OK-Jd
	for qemu-devel@nongnu.org; Thu, 15 Mar 2012 17:28:09 -0400
Message-ID: <4F625EE7.9090402@weilnetz.de>
Date: Thu, 15 Mar 2012 22:28:07 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1330969225-25287-1-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1330969225-25287-1-git-send-email-pbonzini@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/7] block: convert VDI image format to
	coroutines
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: kwolf@redhat.com
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

Am 05.03.2012 18:40, schrieb Paolo Bonzini:
> Conversion to coroutines simplifies the code and removes the need to
> duplicate common features of the block layer. Each step in the conversion
> is detailed in the corresponding commit message.
>
> Tested with qemu-iotests.
>
> Paolo Bonzini (7):
> vdi: basic conversion to coroutines
> vdi: move end-of-I/O handling at the end
> vdi: merge aio_read_cb and aio_write_cb into callers
> vdi: move aiocb fields to locals
> vdi: leave bounce buffering to block layer
> vdi: do not create useless iovecs
> vdi: change goto to loop
>
> block/vdi.c | 421 +++++++++++++-------------------------------------
> 2 files changed, 108 insertions(+), 317 deletions(-)

Acked-by: Stefan Weil <sw@weilnetz.de>

Kevin, could you please add Paolo's patches to your block queue?

I did not review each single patch in detail, but the resulting
code looks sane and much better (and shorter) than the current code
(a little like my original code before I had to add asynchronous
I/O support).

As Paolo already tested with qemu-iotests, I did not re-run those
tests.

Thanks,
Stefan W.