Re: [Qemu-devel] [RFC][PATCH 08/14 v9] target-i386: Add API to write cpu status to core file

[Wen Congyang <wency@cn.fujitsu.com>]

At 03/16/2012 09:48 AM, HATAYAMA Daisuke Wrote:
> From: Wen Congyang <wency@cn.fujitsu.com>
> Subject: [RFC][PATCH 08/14 v9] target-i386: Add API to write cpu status to core file
> Date: Wed, 14 Mar 2012 10:09:26 +0800
> 
>> +    memset(note, 0, note_size);
>> +    if (type == 0) {
>> +        note32 = note;
>> +        note32->n_namesz = cpu_to_le32(name_size);
>> +        note32->n_descsz = cpu_to_le32(descsz);
>> +        note32->n_type = 0;
>> +    } else {
>> +        note64 = note;
>> +        note64->n_namesz = cpu_to_le32(name_size);
>> +        note64->n_descsz = cpu_to_le32(descsz);
>> +        note64->n_type = 0;
>> +    }
> 
> Why not give new type for this note information an explicit name?
> Like NT_QEMUCPUSTATE? There might be another type in the future. This
> way there's also a merit that we can know all the existing notes
> relevant to qemu dump by looking at the names in a header file.

Hmm, how to add a new type? Does someont manage this?

Thanks
Wen Congyang

> 
> Thanks.
> HATAYAMA, Daisuke
> 
>