From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:52883)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1S8QyF-0002uI-9m
	for qemu-devel@nongnu.org; Fri, 16 Mar 2012 02:49:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1S8Qy9-0005cA-2t
	for qemu-devel@nongnu.org; Fri, 16 Mar 2012 02:49:02 -0400
Received: from [222.73.24.84] (port=53485 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1S8Qy8-0005bq-OU
	for qemu-devel@nongnu.org; Fri, 16 Mar 2012 02:48:57 -0400
Message-ID: <4F62E2CA.4@cn.fujitsu.com>
Date: Fri, 16 Mar 2012 14:50:50 +0800
From: Wen Congyang <wency@cn.fujitsu.com>
MIME-Version: 1.0
References: <4F5FFC63.3060300@cn.fujitsu.com>	<4F5FFD74.1060102@cn.fujitsu.com>
	<20120316.125214.115908840.d.hatayama@jp.fujitsu.com>
In-Reply-To: <20120316.125214.115908840.d.hatayama@jp.fujitsu.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [Qemu-devel] [RFC][PATCH 05/14 v9] Add API to get memory mapping
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: HATAYAMA Daisuke <d.hatayama@jp.fujitsu.com>
Cc: jan.kiszka@siemens.com, anderson@redhat.com, qemu-devel@nongnu.org, eblake@redhat.com, lcapitulino@redhat.com

At 03/16/2012 11:52 AM, HATAYAMA Daisuke Wrote:
> From: Wen Congyang <wency@cn.fujitsu.com>
> Subject: [RFC][PATCH 05/14 v9] Add API to get memory mapping
> Date: Wed, 14 Mar 2012 10:07:48 +0800
> 
>>  }
>> +
>> +int qemu_get_guest_memory_mapping(MemoryMappingList *list)
>> +{
>> +    CPUState *env;
>> +    RAMBlock *block;
>> +    ram_addr_t offset, length;
>> +    int ret;
>> +    bool paging_mode;
>> +
>> +#if defined(CONFIG_HAVE_GET_MEMORY_MAPPING)
>> +    paging_mode = cpu_paging_enabled(first_cpu);
>> +    if (paging_mode) {
>> +        for (env = first_cpu; env != NULL; env = env->next_cpu) {
>> +            ret = cpu_get_memory_mapping(list, env);
>> +            if (ret < 0) {
>> +                return -1;
>> +            }
>> +        }
>> +        return 0;
>> +    }
>> +#else
>> +    return -2;
>> +#endif
> 
> Is it better to define the below somewhere else?
> 
> #ifndef CONFIG_HAVE_GET_MEMORY_MAPPING
> static inline int qemu_get_guest_memory_mapping(MemoryMappingList *list)
> {
> 	return -2;
> }
> #endif

Yes

Thanks
Wen Congyang

> 
> Thanks.
> HATAYAMA, Daisuke
> 
>