From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42295) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8To4-0006yV-8i for qemu-devel@nongnu.org; Fri, 16 Mar 2012 05:50:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S8To2-0005ra-3N for qemu-devel@nongnu.org; Fri, 16 Mar 2012 05:50:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40846) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8To1-0005rV-Qi for qemu-devel@nongnu.org; Fri, 16 Mar 2012 05:50:42 -0400 Message-ID: <4F630DC5.7010204@redhat.com> Date: Fri, 16 Mar 2012 10:54:13 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1330969225-25287-1-git-send-email-pbonzini@redhat.com> <1330969225-25287-6-git-send-email-pbonzini@redhat.com> In-Reply-To: <1330969225-25287-6-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/7] vdi: leave bounce buffering to block layer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: sw@weilnetz.de, qemu-devel@nongnu.org Am 05.03.2012 18:40, schrieb Paolo Bonzini: > vdi.c really works as if it implemented bdrv_read and bdrv_write. > However, because only vector I/O is supported by the asynchronous > callbacks, it went through extra pain to bounce-buffer the I/O. > With the conversion to coroutines bdrv_read and bdrv_write are now > asynchronous, so they can be handled by the block layer now that the > format is coroutine-based. > > Signed-off-by: Paolo Bonzini In the long run, the right thing to do would be to convert VDI to deal with vectored I/O, of course. Stefan, maybe you want to do that on top. It's not that hard, I did it for qcow2 a while ago. Kevin