From: Paolo Bonzini <pbonzini@redhat.com>
To: Dmitry Fleytman <dmitry.fleytman@ravellosystems.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Alex Fishman <alex.fishman@ravellosystems.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
yvugenfi@redhat.com, Izik Eidus <izik.eidus@ravellosystems.com>,
qemu-devel@nongnu.org, Dmitry Fleytman <dmitry@daynix.com>,
Yan Vugenfirer <yan@daynix.com>
Subject: Re: [Qemu-devel] [PATCH v4 9/9] VMXNET3 paravirtualized device integration. Interface type "vmxnet3" added.
Date: Fri, 16 Mar 2012 12:35:42 +0100 [thread overview]
Message-ID: <4F63258E.4070502@redhat.com> (raw)
In-Reply-To: <1331845748-6026-10-git-send-email-dmitry.fleytman@ravellosystems.com>
Il 15/03/2012 22:09, Dmitry Fleytman ha scritto:
> Signed-off-by: Dmitry Fleytman <dmitry@daynix.com>
> Signed-off-by: Yan Vugenfirer <yan@daynix.com>
> ---
> Makefile.objs | 1 +
> default-configs/pci.mak | 1 +
> hw/pci.c | 2 ++
> hw/pci.h | 1 +
> net.c | 2 +-
> 5 files changed, 6 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile.objs b/Makefile.objs
> index 226b01d..1366e86 100644
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -284,6 +284,7 @@ hw-obj-$(CONFIG_PCNET_PCI) += pcnet-pci.o
> hw-obj-$(CONFIG_PCNET_COMMON) += pcnet.o
> hw-obj-$(CONFIG_E1000_PCI) += e1000.o
> hw-obj-$(CONFIG_RTL8139_PCI) += rtl8139.o
> +hw-obj-$(CONFIG_VMXNET3_PCI) += vmxnet3.o vmxnet_utils.o vmxnet_pkt.o
>
> hw-obj-$(CONFIG_SMC91C111) += smc91c111.o
> hw-obj-$(CONFIG_LAN9118) += lan9118.o
> diff --git a/default-configs/pci.mak b/default-configs/pci.mak
> index 21e4ccf..f8e6ee1 100644
> --- a/default-configs/pci.mak
> +++ b/default-configs/pci.mak
> @@ -13,6 +13,7 @@ CONFIG_PCNET_COMMON=y
> CONFIG_LSI_SCSI_PCI=y
> CONFIG_RTL8139_PCI=y
> CONFIG_E1000_PCI=y
> +CONFIG_VMXNET3_PCI=y
> CONFIG_IDE_CORE=y
> CONFIG_IDE_QDEV=y
> CONFIG_IDE_PCI=y
These parts should be included in part 8.
Paolo
> diff --git a/hw/pci.c b/hw/pci.c
> index 9146d3f..e2b0045 100644
> --- a/hw/pci.c
> +++ b/hw/pci.c
> @@ -1355,6 +1355,7 @@ static const char * const pci_nic_models[] = {
> "e1000",
> "pcnet",
> "virtio",
> + "vmxnet3",
> NULL
> };
>
> @@ -1367,6 +1368,7 @@ static const char * const pci_nic_names[] = {
> "e1000",
> "pcnet",
> "virtio-net-pci",
> + "vmxnet3",
> NULL
> };
>
> diff --git a/hw/pci.h b/hw/pci.h
> index 4f19fdb..fee8250 100644
> --- a/hw/pci.h
> +++ b/hw/pci.h
> @@ -60,6 +60,7 @@
> #define PCI_DEVICE_ID_VMWARE_NET 0x0720
> #define PCI_DEVICE_ID_VMWARE_SCSI 0x0730
> #define PCI_DEVICE_ID_VMWARE_IDE 0x1729
> +#define PCI_DEVICE_ID_VMWARE_VMXNET3 0x07B0
>
> /* Intel (0x8086) */
> #define PCI_DEVICE_ID_INTEL_82551IT 0x1209
> diff --git a/net.c b/net.c
> index c34474f..e2f586c 100644
> --- a/net.c
> +++ b/net.c
> @@ -857,7 +857,7 @@ static const struct {
> }, {
> .name = "model",
> .type = QEMU_OPT_STRING,
> - .help = "device model (e1000, rtl8139, virtio etc.)",
> + .help = "device model (e1000, rtl8139, virtio, vmxnet3 etc.)",
> }, {
> .name = "addr",
> .type = QEMU_OPT_STRING,
next prev parent reply other threads:[~2012-03-16 11:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-15 21:08 [Qemu-devel] [PATCH v4 0/9] VMXNET3 paravirtual NIC device implementation Dmitry Fleytman
2012-03-15 21:09 ` [Qemu-devel] [PATCH v4 1/9] Adding missing flag VIRTIO_NET_HDR_F_DATA_VALID from Linux kernel source tre Reformatting comments according to checkpatch.pl requirements Dmitry Fleytman
2012-03-15 21:09 ` [Qemu-devel] [PATCH v4 2/9] Adding utility function net_checksum_add_cont() that allows checksum calculation of scattered data with odd chunk sizes Dmitry Fleytman
2012-03-15 21:09 ` [Qemu-devel] [PATCH v4 3/9] Adding utility function iov_net_csum_add() for iovec checksum calculation Dmitry Fleytman
2012-03-15 21:09 ` [Qemu-devel] [PATCH v4 4/9] MSI-X state save/load invocations moved to PCI Device save/load callbacks to avoid code duplication in MSI-X-enabled devices that support live migration Dmitry Fleytman
2012-03-15 23:00 ` Michael S. Tsirkin
2012-03-16 9:18 ` Dmitry Fleytman
2012-03-15 21:09 ` [Qemu-devel] [PATCH v4 5/9] Header with various utility functions shared by VMWARE SCSI and network devi Dmitry Fleytman
2012-03-15 21:09 ` [Qemu-devel] [PATCH v4 6/9] Various utility functions used by VMWARE network devices Dmitry Fleytman
2012-03-15 21:09 ` [Qemu-devel] [PATCH v4 7/9] Packet abstraction " Dmitry Fleytman
2012-03-15 21:09 ` [Qemu-devel] [PATCH v4 8/9] VMXNET3 paravirtual device implementation Dmitry Fleytman
2012-03-15 21:09 ` [Qemu-devel] [PATCH v4 9/9] VMXNET3 paravirtualized device integration. Interface type "vmxnet3" added Dmitry Fleytman
2012-03-16 11:35 ` Paolo Bonzini [this message]
2012-03-18 9:26 ` Dmitry Fleytman
2012-03-18 8:29 ` [Qemu-devel] [PATCH v4 0/9] VMXNET3 paravirtual NIC device implementation Gerhard Wiesinger
2012-03-18 15:30 ` Dmitry Fleytman
2012-03-19 19:24 ` Gerhard Wiesinger
2012-03-20 8:00 ` Dmitry Fleytman
2012-03-21 6:59 ` Gerhard Wiesinger
2012-03-25 6:39 ` Gerhard Wiesinger
2012-03-18 8:32 ` Gerhard Wiesinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F63258E.4070502@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.fishman@ravellosystems.com \
--cc=aliguori@us.ibm.com \
--cc=dmitry.fleytman@ravellosystems.com \
--cc=dmitry@daynix.com \
--cc=izik.eidus@ravellosystems.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yan@daynix.com \
--cc=yvugenfi@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).