From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40411)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1S8X3G-0007gi-C5
	for qemu-devel@nongnu.org; Fri, 16 Mar 2012 09:18:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1S8X3B-000551-I9
	for qemu-devel@nongnu.org; Fri, 16 Mar 2012 09:18:37 -0400
Received: from mail-gx0-f173.google.com ([209.85.161.173]:41402)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1S8X3B-00054n-CK
	for qemu-devel@nongnu.org; Fri, 16 Mar 2012 09:18:33 -0400
Received: by ggnj2 with SMTP id j2so4781011ggn.4
	for <qemu-devel@nongnu.org>; Fri, 16 Mar 2012 06:18:31 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4F633DA0.2090900@redhat.com>
Date: Fri, 16 Mar 2012 14:18:24 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <541C8B7E-1E25-479E-B69E-A4B58BFA45F3@nowonline.co.uk>
In-Reply-To: <541C8B7E-1E25-479E-B69E-A4B58BFA45F3@nowonline.co.uk>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] fix incorrect bracket in tracetool
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Lee Essen <lee.essen@nowonline.co.uk>
Cc: =?ISO-8859-1?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>, Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org

Il 16/03/2012 13:29, Lee Essen ha scritto:
> @@ -123,7 +123,7 @@ get_argc()
>  # Get the format string including double quotes for a trace event
>  get_fmt()
>  {
> -    puts "${1#*)}"
> +    puts "${1#*}"
>  }
>  

Eric, can you look at this?  Is it a bashism or a Solaris bug?

I would write it, to be entirely safe, as

   local fmt
   fmt=${1#*\)}
   puts "$fmt"

where I'm using the extra variable to avoid the ambiguity of quoting the
parentheses within quotes; variable assignments are always implicitly
quoted.

Paolo