From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8bgE-0006XS-OI for qemu-devel@nongnu.org; Fri, 16 Mar 2012 14:15:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S8bgD-0005t5-2j for qemu-devel@nongnu.org; Fri, 16 Mar 2012 14:15:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60052) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S8bgC-0005sh-RI for qemu-devel@nongnu.org; Fri, 16 Mar 2012 14:15:09 -0400 Message-ID: <4F638328.7000309@redhat.com> Date: Fri, 16 Mar 2012 19:15:04 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <4F632A56.5040305@redhat.com> <0A468378-02CE-4CEE-868C-3DE8B34C3AF2@nowonline.co.uk> In-Reply-To: <0A468378-02CE-4CEE-868C-3DE8B34C3AF2@nowonline.co.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Initial support for Ilumos build and Illumos-kvm List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lee Essen Cc: =?windows-1252?Q?Andreas_F=E4rber?= , qemu-devel@nongnu.org Il 16/03/2012 18:25, Lee Essen ha scritto: > Correct =85 but actually this raises another question =85 why create a = separate pointer to kvm_state=85 >=20 > KVMState *s =3D kvm_state; >=20 > =85 why not just use kvm_state throughout the function? >=20 > This seems to be a common approach in many of the functions in kvm-all.= c =85 is there a reason? It's historical due to the way things were done in the qemu-kvm fork. It was done this way in order to let qemu.git and qemu-kvm.git share a bit more code, IIUC. Paolo