From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60343) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9DMx-0004TU-6A for qemu-devel@nongnu.org; Sun, 18 Mar 2012 06:29:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S9DMc-00012E-VX for qemu-devel@nongnu.org; Sun, 18 Mar 2012 06:29:46 -0400 Received: from p15195424.pureserver.info ([82.165.34.74]:56971) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9DMc-00011y-PP for qemu-devel@nongnu.org; Sun, 18 Mar 2012 06:29:26 -0400 Message-ID: <4F65B906.6040203@ilande.co.uk> Date: Sun, 18 Mar 2012 10:29:26 +0000 From: Mark Cave-Ayland MIME-Version: 1.0 References: <4F6541FC.8080702@ilande.co.uk> <4F65AE7B.8010101@redhat.com> In-Reply-To: <4F65AE7B.8010101@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Blue Swirl , qemu-devel@nongnu.org On 18/03/12 09:44, Avi Kivity wrote: >> Hi Avi/Blue, >> >> I've just updated to git master and found that SPARC64 is broken >> again; a git bisect shows the following commit causes this: >> >> >> commit f3705d53296d78b14f5823472ae2add16a25a0a5 >> Author: Avi Kivity >> Date: Thu Mar 8 16:16:34 2012 +0200 >> >> memory: make phys_page_find() return an unadjusted section >> >> We'd like to store the section index in the iotlb, so we can't >> adjust it before returning. Return an unadjusted section and >> instead introduce section_addr(), which does the adjustment later. >> >> Signed-off-by: Avi Kivity >> >> >> The symptom is that qemu-system-sparc64 segfaults immediately on >> startup (note this is with an OpenBIOS image built from SVN r1048). >> I've included a couple of backtraces below: >> > > Please try the attached patch. > > If it fails, can you upload bios and disk images somewhere? Hi Avi/Blue, I can confirm that both patches work for me and enable SPARC64 to boot - Blue, what is the VGA display issue that you mention? I didn't see any display corruption when testing on both SPARC64 and PPC. Upon inspection I see that Blue's patch seems to be a more of a global fix, whereas Avi's seems restricted to SPARC. Does that make Blue's patch a "better" solution since it will resolve the same undiscovered issue in other targets that make the same assumption? Many thanks, Mark.