From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60638)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1S9DOp-0005zl-DV
	for qemu-devel@nongnu.org; Sun, 18 Mar 2012 06:31:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1S9DOn-0001JR-Nr
	for qemu-devel@nongnu.org; Sun, 18 Mar 2012 06:31:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:11545)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1S9DOn-0001JJ-B5
	for qemu-devel@nongnu.org; Sun, 18 Mar 2012 06:31:41 -0400
Message-ID: <4F65B984.9040501@redhat.com>
Date: Sun, 18 Mar 2012 12:31:32 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <4F6541FC.8080702@ilande.co.uk> <4F65AE7B.8010101@redhat.com>
	<CAAu8pHt6DjdtumFDT2+SoyEnDhyMJcnjV8ouAFhO4M17=J1_iA@mail.gmail.com>
In-Reply-To: <CAAu8pHt6DjdtumFDT2+SoyEnDhyMJcnjV8ouAFhO4M17=J1_iA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] SPARC64: immediate segfault on startup with git
 mastervery
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, qemu-devel@nongnu.org

On 03/18/2012 11:51 AM, Blue Swirl wrote:
> On Sun, Mar 18, 2012 at 09:44, Avi Kivity <avi@redhat.com> wrote:
> > On 03/18/2012 04:01 AM, Mark Cave-Ayland wrote:
> >> Hi Avi/Blue,
> >>
> >> I've just updated to git master and found that SPARC64 is broken
> >> again; a git bisect shows the following commit causes this:
> >>
> >>
> >> commit f3705d53296d78b14f5823472ae2add16a25a0a5
> >> Author: Avi Kivity <avi@redhat.com>
> >> Date:   Thu Mar 8 16:16:34 2012 +0200
> >>
> >>     memory: make phys_page_find() return an unadjusted section
> >>
> >>     We'd like to store the section index in the iotlb, so we can't
> >>     adjust it before returning.  Return an unadjusted section and
> >>     instead introduce section_addr(), which does the adjustment later.
> >>
> >>     Signed-off-by: Avi Kivity <avi@redhat.com>
> >>
> >>
> >> The symptom is that qemu-system-sparc64 segfaults immediately on
> >> startup (note this is with an OpenBIOS image built from SVN r1048).
> >> I've included a couple of backtraces below:
> >>
> >
> > Please try the attached patch.
>
> I tried this approach instead, seems to work 

IMO, my patch is better.  tlb_set_page() should not deal with offsets
within a page.

If you prefer your approach, I suggest masking the address up front in
the beginning of tlb_set_page() instead.

> (except Sparc32, Sparc64
> and PPC displays are still not refreshed correctly).

Details about this please.


-- 
error compiling committee.c: too many arguments to function