From: Avi Kivity <avi@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery
Date: Sun, 18 Mar 2012 14:08:00 +0200 [thread overview]
Message-ID: <4F65D020.5000400@redhat.com> (raw)
In-Reply-To: <CAAu8pHvjuv5g3svZ0ZRJcYqvHg=d3SLkpGXE7GOJBY69APbo0Q@mail.gmail.com>
On 03/18/2012 12:51 PM, Blue Swirl wrote:
> >
> > IMO, my patch is better. tlb_set_page() should not deal with offsets
> > within a page.
>
> It looks like all targets except Sparc32/64 mask the addresses before
> passing to tlb_set_page(), so I agree.
Ok. Commit my patch then?
> > If you prefer your approach, I suggest masking the address up front in
> > the beginning of tlb_set_page() instead.
> >
> >> (except Sparc32, Sparc64
> >> and PPC displays are still not refreshed correctly).
> >
> > Details about this please.
>
> Screen is not updated correctly, there are lines from previous
> screenful. Pressing ctrl-alt-1 refreshes the display. Perhaps dirty
> tracking is broken? VGA in x86 works.
Ok, I see it. Will investigate.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2012-03-18 12:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-18 2:01 [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery Mark Cave-Ayland
2012-03-18 9:44 ` Avi Kivity
2012-03-18 9:51 ` Blue Swirl
2012-03-18 10:31 ` Avi Kivity
2012-03-18 10:51 ` Blue Swirl
2012-03-18 11:03 ` Mark Cave-Ayland
2012-03-18 11:28 ` Blue Swirl
2012-03-18 12:08 ` Avi Kivity [this message]
2012-03-18 12:10 ` Blue Swirl
2012-03-18 12:13 ` Avi Kivity
2012-03-18 12:15 ` Blue Swirl
2012-03-18 15:36 ` Avi Kivity
2012-03-18 9:57 ` Blue Swirl
2012-03-18 10:29 ` Mark Cave-Ayland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F65D020.5000400@redhat.com \
--to=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).