From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56180) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9EuD-0003IB-W3 for qemu-devel@nongnu.org; Sun, 18 Mar 2012 08:08:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S9EuC-0006hn-G5 for qemu-devel@nongnu.org; Sun, 18 Mar 2012 08:08:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60543) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9EuC-0006hi-81 for qemu-devel@nongnu.org; Sun, 18 Mar 2012 08:08:12 -0400 Message-ID: <4F65D020.5000400@redhat.com> Date: Sun, 18 Mar 2012 14:08:00 +0200 From: Avi Kivity MIME-Version: 1.0 References: <4F6541FC.8080702@ilande.co.uk> <4F65AE7B.8010101@redhat.com> <4F65B984.9040501@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Mark Cave-Ayland , qemu-devel@nongnu.org On 03/18/2012 12:51 PM, Blue Swirl wrote: > > > > IMO, my patch is better. tlb_set_page() should not deal with offsets > > within a page. > > It looks like all targets except Sparc32/64 mask the addresses before > passing to tlb_set_page(), so I agree. Ok. Commit my patch then? > > If you prefer your approach, I suggest masking the address up front in > > the beginning of tlb_set_page() instead. > > > >> (except Sparc32, Sparc64 > >> and PPC displays are still not refreshed correctly). > > > > Details about this please. > > Screen is not updated correctly, there are lines from previous > screenful. Pressing ctrl-alt-1 refreshes the display. Perhaps dirty > tracking is broken? VGA in x86 works. Ok, I see it. Will investigate. -- error compiling committee.c: too many arguments to function