From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44649) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9Ez2-0006X5-W4 for qemu-devel@nongnu.org; Sun, 18 Mar 2012 08:13:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S9Ez1-0007NY-7j for qemu-devel@nongnu.org; Sun, 18 Mar 2012 08:13:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29056) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9Ez0-0007NL-W4 for qemu-devel@nongnu.org; Sun, 18 Mar 2012 08:13:11 -0400 Message-ID: <4F65D14F.2040605@redhat.com> Date: Sun, 18 Mar 2012 14:13:03 +0200 From: Avi Kivity MIME-Version: 1.0 References: <4F6541FC.8080702@ilande.co.uk> <4F65AE7B.8010101@redhat.com> <4F65B984.9040501@redhat.com> <4F65D020.5000400@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] SPARC64: immediate segfault on startup with git mastervery List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Mark Cave-Ayland , qemu-devel@nongnu.org On 03/18/2012 02:10 PM, Blue Swirl wrote: > On Sun, Mar 18, 2012 at 12:08, Avi Kivity wrote: > > On 03/18/2012 12:51 PM, Blue Swirl wrote: > >> > > >> > IMO, my patch is better. tlb_set_page() should not deal with offsets > >> > within a page. > >> > >> It looks like all targets except Sparc32/64 mask the addresses before > >> passing to tlb_set_page(), so I agree. > > > > Ok. Commit my patch then? > > I sent a different patch which masks incoming address earlier and > removes unnecessary masking in other places. My patch missed the "boot mode" thing. Does your patch fix it? -- error compiling committee.c: too many arguments to function