From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35431)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1S9TB0-0004MN-D6
	for qemu-devel@nongnu.org; Sun, 18 Mar 2012 23:22:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jasowang@redhat.com>) id 1S9TAy-00005x-Pv
	for qemu-devel@nongnu.org; Sun, 18 Mar 2012 23:22:29 -0400
Message-ID: <4F66A66A.20000@redhat.com>
Date: Mon, 19 Mar 2012 11:22:18 +0800
From: Jason Wang <jasowang@redhat.com>
MIME-Version: 1.0
References: <20120316091044.6166.86916.stgit@amd-6168-8-1.englab.nay.redhat.com>
	<4F6316D0.6010105@suse.de>
In-Reply-To: <4F6316D0.6010105@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RESEND PATCH] ioapic: fix build with DEBUG_IOAPIC
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

On 03/16/2012 06:32 PM, Andreas F=C3=A4rber wrote:
> Am 16.03.2012 10:10, schrieb Jason Wang:
>> ioapic.c:198: error: format =E2=80=98%08x=E2=80=99 expects type =E2=80=
=98unsigned int=E2=80=99, but argument 3 has type =E2=80=98uint64_t=E2=80=
=99
>>
>> Signed-off-by: Jason Wang<jasowang@redhat.com>
> PRIx64 is indeed needed here. However, this drops the 08 without mentio=
n
> in the commit message - was it intended?

Not intended, my fault, thanks for pointing this.
> Andreas
>
>> ---
>>   hw/ioapic.c |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/hw/ioapic.c b/hw/ioapic.c
>> index 3fee011..1ff31a1 100644
>> --- a/hw/ioapic.c
>> +++ b/hw/ioapic.c
>> @@ -195,7 +195,7 @@ ioapic_mem_write(void *opaque, target_phys_addr_t =
addr, uint64_t val,
>>           if (size !=3D 4) {
>>               break;
>>           }
>> -        DPRINTF("write: %08x =3D %08x\n", s->ioregsel, val);
>> +        DPRINTF("write: %08x =3D %" PRIx64 "\n", s->ioregsel, val);
>>           switch (s->ioregsel) {
>>           case IOAPIC_REG_ID:
>>               s->id =3D (val>>  IOAPIC_ID_SHIFT)&  IOAPIC_ID_MASK;