From: "Andreas Färber" <afaerber@suse.de>
To: Jason Wang <jasowang@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [REPOST PATCH] ioapic: fix build with DEBUG_IOAPIC
Date: Mon, 19 Mar 2012 11:05:18 +0100 [thread overview]
Message-ID: <4F6704DE.5040209@suse.de> (raw)
In-Reply-To: <20120319031957.17031.94258.stgit@amd-6168-8-1.englab.nay.redhat.com>
Am 19.03.2012 04:19, schrieb Jason Wang:
> ioapic.c:198: error: format ‘%08x’ expects type ‘unsigned int’, but argument 3 has type ‘uint64_t’
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Thanks,
Andreas
> ---
> hw/ioapic.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/ioapic.c b/hw/ioapic.c
> index 3fee011..e2e4796 100644
> --- a/hw/ioapic.c
> +++ b/hw/ioapic.c
> @@ -195,7 +195,7 @@ ioapic_mem_write(void *opaque, target_phys_addr_t addr, uint64_t val,
> if (size != 4) {
> break;
> }
> - DPRINTF("write: %08x = %08x\n", s->ioregsel, val);
> + DPRINTF("write: %08x = %08" PRIx64 "\n", s->ioregsel, val);
> switch (s->ioregsel) {
> case IOAPIC_REG_ID:
> s->id = (val >> IOAPIC_ID_SHIFT) & IOAPIC_ID_MASK;
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2012-03-19 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-19 3:19 [Qemu-devel] [REPOST PATCH] ioapic: fix build with DEBUG_IOAPIC Jason Wang
2012-03-19 8:49 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2012-03-19 10:05 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6704DE.5040209@suse.de \
--to=afaerber@suse.de \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).