From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39964) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9ZZ2-0002jA-E3 for qemu-devel@nongnu.org; Mon, 19 Mar 2012 06:11:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S9ZYt-0001Ul-SJ for qemu-devel@nongnu.org; Mon, 19 Mar 2012 06:11:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:14496) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S9ZYt-0001UK-Js for qemu-devel@nongnu.org; Mon, 19 Mar 2012 06:11:35 -0400 Message-ID: <4F670650.2000901@redhat.com> Date: Mon, 19 Mar 2012 12:11:28 +0200 From: Avi Kivity MIME-Version: 1.0 References: <20120313103602.8741.71939.stgit@dhcp-8-167.nay.redhat.com> <4F606356.9080003@redhat.com> <4F606D84.8000807@redhat.com> <4F6076EE.9090005@redhat.com> <4F6300F7.6080806@redhat.com> In-Reply-To: <4F6300F7.6080806@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] virtio-pci: fix abort when fail to allocate ioeventfd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amos Kong Cc: aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, kvm@vger.kernel.org, Stefan Hajnoczi , mtosatti@redhat.com, qemu-devel@nongnu.org On 03/16/2012 10:59 AM, Amos Kong wrote: > > Can you give some detail about this? I'm not familiar with Memory API. Well there's a huge amount of detail needed here. The idea is that memory_region_add_eventfd() will always work, with or without kvm, and even if kvm is enabled but we run out of ioeventfds. One way to do this is to implement core_eventfd_add() in exec.c. This is unlikely to be easy however. > > btw, can we fix this problem by replacing abort() by a error note? > virtio-pci will auto fallback to userspace. But other users will silently break, need to audit all other users of ioeventfd, for example ivshmem. -- error compiling committee.c: too many arguments to function