From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37786)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1S9a8S-0004xf-05
	for qemu-devel@nongnu.org; Mon, 19 Mar 2012 06:48:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1S9a8L-0007xy-S4
	for qemu-devel@nongnu.org; Mon, 19 Mar 2012 06:48:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39418)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1S9a8L-0007x1-KG
	for qemu-devel@nongnu.org; Mon, 19 Mar 2012 06:48:13 -0400
Message-ID: <4F670EE9.6000100@redhat.com>
Date: Mon, 19 Mar 2012 12:48:09 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
References: <1331227233-18601-1-git-send-email-avi@redhat.com>
	<1331227233-18601-6-git-send-email-avi@redhat.com>
	<CAETRQWkLdzRpmKL_dL=fg4yVfdiKEHET9kb7NHw6swyAxLaKJQ@mail.gmail.com>
	<4F66F95D.4000608@redhat.com>
	<CAETRQW=pEqa4cObyTQwmOQHJBuWjURV2bhFisCQeFoHyuTwjLw@mail.gmail.com>
In-Reply-To: <CAETRQW=pEqa4cObyTQwmOQHJBuWjURV2bhFisCQeFoHyuTwjLw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/5] memory: get rid of
	cpu_register_io_memory()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: TeLeMan <geleman@gmail.com>
Cc: qemu-devel@nongnu.org

On 03/19/2012 12:37 PM, TeLeMan wrote:
> On Mon, Mar 19, 2012 at 17:16, Avi Kivity <avi@redhat.com> wrote:
> > On 03/19/2012 06:52 AM, TeLeMan wrote:
> >> >  static bool memory_region_wrong_endianness(MemoryRegion *mr)
> >> > @@ -942,7 +940,7 @@ void memory_region_init_io(MemoryRegion *mr,
> >> >     mr->opaque = opaque;
> >> >     mr->terminates = true;
> >> >     mr->destructor = memory_region_destructor_iomem;
> >> > -    mr->ram_addr = cpu_register_io_memory(mr);
> >> > +    mr->ram_addr = ~(ram_addr_t)0;
> >> Why not 0 but -1?
> >>
> >
> > To catch bugs.  In fact it triggered bugs (not the ones I wanted though).
> There may be BSOD on the guest windows xp after applying this patch.
>

May? Where?

-- 
error compiling committee.c: too many arguments to function