qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Richard Henderson <rth@twiddle.net>
Cc: Riku Voipio <riku.voipio@iki.fi>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] alpha-user: Initialize FPCR with round-to-nearest.
Date: Mon, 19 Mar 2012 12:01:07 +0100	[thread overview]
Message-ID: <4F6711F3.5000503@suse.de> (raw)
In-Reply-To: <4F64E657.1070800@twiddle.net>

Am 17.03.2012 20:30, schrieb Richard Henderson:
> Ping.

This is linux-user, so cc'ing Riku.

Code looks sane at first sight although I have no clue of the constants'
meaning and effect. ;)

Commit message doesn't mention it but I guess this fixes some bug? How
does it round before the patch?

Andreas

> 
> On 03/11/2012 11:54 AM, Richard Henderson wrote:
>> Signed-off-by: Richard Henderson <rth@twiddle.net>
>> ---
>>  target-alpha/translate.c |    3 ++-
>>  1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/target-alpha/translate.c b/target-alpha/translate.c
>> index 1d2142b..fe78630 100644
>> --- a/target-alpha/translate.c
>> +++ b/target-alpha/translate.c
>> @@ -3513,7 +3513,8 @@ CPUAlphaState * cpu_alpha_init (const char *cpu_model)
>>  #if defined (CONFIG_USER_ONLY)
>>      env->ps = PS_USER_MODE;
>>      cpu_alpha_store_fpcr(env, (FPCR_INVD | FPCR_DZED | FPCR_OVFD
>> -                               | FPCR_UNFD | FPCR_INED | FPCR_DNOD));
>> +                               | FPCR_UNFD | FPCR_INED | FPCR_DNOD
>> +                               | FPCR_DYN_NORMAL));
>>  #endif
>>      env->lock_addr = -1;
>>      env->fen = 1;

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

  reply	other threads:[~2012-03-19 11:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-11 18:54 [Qemu-devel] [PATCH] alpha-user: Initialize FPCR with round-to-nearest Richard Henderson
2012-03-17 19:30 ` Richard Henderson
2012-03-19 11:01   ` Andreas Färber [this message]
2012-03-19 13:32     ` Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F6711F3.5000503@suse.de \
    --to=afaerber@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=riku.voipio@iki.fi \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).